[theme-reviewers] WordPress Shortcodes

[Daniel Fenn]

+1 Chip

On 31/12/2011, Chip Bennett <chip at chipbennett.net> wrote:
> What happens to that *content* when the user switches Themes? Buh-bye
> contact form, Google chart, etc.
>
> Those shortcodes really belong in Plugins. They are content creation, not
> content presentation.
>
> Chip
>
> On Fri, Dec 30, 2011 at 8:48 PM, Emil Uzelac <emil at themeid.com> wrote:
>
>> Not sure, this was a quick scan-over that's all. I personally don't see
>> anything wrong with the usage itself if they were error-free.
>>
>> Emil
>>
>>
>> *----*
>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>> emil at themeid.com | http://themeid.com
>> Make everything as simple as possible, but not simpler. - Albert Einstein
>>
>>
>>
>> On Fri, Dec 30, 2011 at 7:44 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>
>>> Why is a Google Chart shortcode included in a *Theme*, rather than in a
>>> Plugin?
>>>
>>> Chip
>>>
>>> On Fri, Dec 30, 2011 at 12:27 AM, Emil Uzelac <emil at themeid.com> wrote:
>>>
>>>> Reviewers,
>>>>
>>>> In regards to:
>>>> http://make.wordpress.org/themes/2011/12/15/getting-the-review-queue-back-on-track/and
>>>> http://codex.wordpress.org/Theme_Review#Code_Quality as well, can we
>>>> also make sure that
>>>> Shortcodes<http://codex.wordpress.org/Shortcode_API>are checked as well?
>>>> Shortcodes can produce undefined
>>>> errors <http://php.net/manual/en/function.isset.php> and i.e. Theme
>>>> Check <http://wordpress.org/extend/plugins/theme-check/> will find
>>>> them, however only if you actually use the shortcodes on any given
>>>> page/post. Good example is http://pastebin.com/FEGz56vu (Google Chart)
>>>> all* Themes in repository using this or similar code will have undefined
>>>> error(s). This is only an example. Some will say that this is harmless,
>>>> however we still need error free Themes :)
>>>>
>>>> Thank you all for your help and Happy Holidays!
>>>>
>>>> Emil
>>>>
>>>> *----*
>>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>>> emil at themeid.com | http://themeid.com
>>>> Make everything as simple as possible, but not simpler. - Albert
>>>> Einstein
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>


-- 
Regards,
Daniel Fenn