[theme-reviewers] Ticket 5800
mario at peshev.net
Mon Dec 19 23:14:36 UTC 2011
No worries. Just noticed the only single ticket in the #1 and pinged here
and there. I asked here on purpose instead of discussing in the ticket as
you have sent some notes but didn't assigned the ticket yourself.
All the best,
Training and Consulting Services @ DevriX
On Tue, Dec 20, 2011 at 1:12 AM, Merci Javier <mercijavier at gmail.com> wrote:
> Hi there,
> Sorry I was incommunicado for a while.
> I test BuddyPress themes up for review against current WP and BP versions.
> BP themes or BP child themes which may have been previously approved for
> older BP versions like 1.2+ (like most of the "buddypress" themes in WP
> theme repo) fail in current BP 1.5.2 version. So for me, review of BP
> themes submitted should be more than a diff review.
> Custom Community theme passed for BP 1.5 where I focused on the BP
> template changes and missed the change in footer credits location. But even
> if there were only CSS changes submitted now, which is not the case for
> this theme, compatibility with the current WP 3.3 and BP 1.5.2 versions
> would require more than CSS changes to cover the points I brought up in the
> ticket alone without even starting the theme review proper:
> 1. footer credits location
> 2. wp_enqueue_scripts() not wp_print_styles
> While the second one is not yet included in our Theme Review guidelines,
> or I may have missed it, the styles did bleed through to the wp-admin area
> with a bp-default child theme which was activated when I upgraded to WP 3.3
> - all orange links in dashboard.
> So if you don't mind Mario, I am free now to take on the review of this
> ticket. Thanks.
> On Mon, Dec 19, 2011 at 1:06 PM, Mario Peshev <mario at peshev.net> wrote:
>> Not really, but since diff changes are CSS only and few very basic
>> conditional statements, I don't see a reason not to be approved as an old
>> Best regards,
>> Mario Peshev
>> Training and Consulting Services @ DevriX
>> On Mon, Dec 19, 2011 at 11:04 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>> That one is a BuddyPress Theme. If you're comfortable with/able to
>>> review BP Themes, please feel free!
>>> On 12/19/11, Mario Peshev <mario at peshev.net> wrote:
>>> > mercime has commented on the #5800 ticket -
>>> > http://themes.trac.wordpress.org/ticket/5800 - with some details that
>>> > lead to approval. From what I see he and Chip has approved the last 3
>>> > releases and my diff review found only style changes and very minor
>>> > customizations. I would personally mark this theme for approve, of
>>> course I
>>> > don't want to affect mercime's progress so far.
>>> > The theme is up and running, some styling has changed only, 5 days have
>>> > passed so far - ready for approval?
>>> > Mario Peshev
>>> > Training and Consulting Services @ DevriX
>>> > http://www.linkedin.com/in/mpeshev
>>> > http://devrix.com
>>> > http://peshev.net/blog
>>> Sent from my mobile device
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers