[theme-reviewers] @rxn Ready for Another Theme

Chip Bennett chip at chipbennett.net
Tue Apr 26 21:02:32 UTC 2011


A quick look at the GitHub repo shows that the script doesn't meet current
guidelines regarding Theme Settings/Data Security:
 - Settings saved to the DB individually, rather than as a single options
array
 - No nonce checking
 - Uses 'manage_options' capability, rather than 'edit_theme_options'
 - Uses add_menu_page() rather than add_theme_page()

(etc, etc, etc)

It is also enqueueing an external version of jQuery-ui, instead of using the
core-bundled version.

Chip

On Tue, Apr 26, 2011 at 3:56 PM, Tammie Lister <karmatosed at gmail.com> wrote:

>  https://github.com/cheezburger/cheezcap
>
> It's a beast there is a huge amount in there and it doesn't seem to fit
> with guidelines in all cases so confirming where we stand on it's use.
>
> The ticket is:  http://themes.trac.wordpress.org/ticket/3423
>
> So far the theme may fail on other grounds (just getting into the test) but
> it is something to consider.
>
> Regards,
> Tammie Lister
>
> On Tuesday, 26 April 2011 at 21:54, Chip Bennett wrote:
>
> What's a Cheezburger Custom Administration Panel?
>
> On Tue, Apr 26, 2011 at 3:51 PM, Tammie Lister <karmatosed at gmail.com>wrote:
>
>  Just a mini query the theme I'm currently checking uses Cheezburger
> Custom Administration Panel.  Confirming this is ok.
>
> Regards,
> Tammie Lister
>
> On Tuesday, 26 April 2011 at 21:45, rex posadas wrote:
>
> Great, Thank you.
> I'm on it.
>
>
> ------------------------------
> *From:* Emil Uzelac <emil at themeid.com>
> *To:* theme-reviewers at lists.wordpress.org
> *Sent:* Sun, April 24, 2011 1:56:58 PM
> *Subject:* Re: [theme-reviewers] @rxn Ready for Another Theme
>
> @rxn
>
> You have one opened (assigned) ticket you requested 4 days ago:
> http://themes.trac.wordpress.org/ticket/3540
>
> Cheers,
> Emil
>
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com/
> Make everything as simple as possible, but not simpler. - Albert Einstein
>
>
>
> On Wed, Apr 20, 2011 at 6:33 PM, rex posadas <rexposadas at yahoo.com> wrote:
>
> Hi,
>
> My previous email must have gotten lost.
>
> Could I have another theme to review?
>
> My username is : rxn
>
> Thank You.
>
> Rex
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>  _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110426/813f1066/attachment-0001.htm>


More information about the theme-reviewers mailing list