[theme-reviewers] Review Request [Karthik K]

Chip Bennett chip at chipbennett.net
Sat Apr 23 12:53:41 UTC 2011


Those kinds of limitations are fine, but need to be documented in
readme.txt.

The current Theme Unit Test data file has 12 top-level Pages. Themes should
handle an "all Pages" menu gracefully, or should document the design
limitation in readme.txt, so users know to limit their menus.

As for the_post_thumbnail(): if the Theme doesn't enable post thumbnail
support via add_theme_support( 'post-thumbnails' ), I wouldn't even mention
it in the review; however, these two function calls *must* be paired. If one
is used, the other is *required* to be used. In other words: if the Theme
calls add_theme_support( 'post-thumbnails' ), then it is *required* to call
the_post_thumbnail() (or equivalent function), and vice versa.

Chip

On Fri, Apr 22, 2011 at 11:23 PM, Emil Uzelac <emil at themeid.com> wrote:

> Well some people will have 15+ items in menu, but there's nothing we can do
> about, as long as the menu is functional it should be all right.
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com
> Make everything as simple as possible, but not simpler. - Albert Einstein
>
>
>
> On Fri, Apr 22, 2011 at 11:21 PM, Karthik K <karthikthephoenix at gmail.com>wrote:
>
>> The menu bar also handles only 6 items. And not more than that. Please
>> suggest me some solution!
>>
>> _
>> Karthik.K
>> Contact Me: [image: Twitter] <http://twitter.com/ImKarthikK>[image:
>> Facebook] <http://www.facebook.com/ImKarthikK>[image: Linkedin]<http://www.linkedin.com/in/karthikk88>[image:
>> Flickr] <http://www.flickr.com/ImKarthikK/show>[image: Youtube]<http://www.youtube.com/ImKarthikK>[image:
>> Blog RSS] <http://www.karthikk.net/>
>>
>>
>>
>>
>> On Sat, Apr 23, 2011 at 9:43 AM, Karthik K <karthikthephoenix at gmail.com>wrote:
>>
>>> Bro,
>>> I've got a query. There is no readme.txt in the theme. And also, no
>>> references to the_post_thumbnails() and many such were not found. Is that
>>> fine with this theme?
>>>
>>> _
>>> Karthik.K
>>> Contact Me: [image: Twitter] <http://twitter.com/ImKarthikK>[image:
>>> Facebook] <http://www.facebook.com/ImKarthikK>[image: Linkedin]<http://www.linkedin.com/in/karthikk88>[image:
>>> Flickr] <http://www.flickr.com/ImKarthikK/show>[image: Youtube]<http://www.youtube.com/ImKarthikK>[image:
>>> Blog RSS] <http://www.karthikk.net/>
>>>
>>>
>>>
>>>
>>> On Sat, Apr 23, 2011 at 9:35 AM, Emil Uzelac <emil at themeid.com> wrote:
>>>
>>>> no worries I won't ;)
>>>> *----*
>>>>  *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>>> emil at themeid.com | http://themeid.com
>>>> Make everything as simple as possible, but not simpler. - Albert
>>>> Einstein
>>>>
>>>>
>>>>
>>>> On Fri, Apr 22, 2011 at 10:59 PM, Karthik K <
>>>> karthikthephoenix at gmail.com> wrote:
>>>>
>>>>> Ha ha ha! I love this. I'm learning a lot. Thanks for guiding me.
>>>>> Please don't stop! :)
>>>>> _
>>>>> Karthik.K
>>>>> Contact Me: [image: Twitter] <http://twitter.com/ImKarthikK>[image:
>>>>> Facebook] <http://www.facebook.com/ImKarthikK>[image: Linkedin]<http://www.linkedin.com/in/karthikk88>[image:
>>>>> Flickr] <http://www.flickr.com/ImKarthikK/show>[image: Youtube]<http://www.youtube.com/ImKarthikK>[image:
>>>>> Blog RSS] <http://www.karthikk.net/>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sat, Apr 23, 2011 at 8:53 AM, Emil Uzelac <emil at themeid.com> wrote:
>>>>>
>>>>>> OK player, here it is http://themes.trac.wordpress.org/ticket/3577
>>>>>>  *----*
>>>>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>>>>> emil at themeid.com | http://themeid.com
>>>>>> Make everything as simple as possible, but not simpler. - Albert
>>>>>> Einstein
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Apr 22, 2011 at 10:10 PM, Karthik.K <
>>>>>> karthikthephoenix at gmail.com> wrote:
>>>>>>
>>>>>>> I'm game for another theme review.
>>>>>>> karthikk88
>>>>>>>
>>>>>>> Sent from my iPhone
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110423/555211a2/attachment-0001.htm>


More information about the theme-reviewers mailing list