[theme-reviewers] [WordPress Themes] Blacklens - feedback

Tue Sep 28 23:54:42 UTC 2010

@Chip ...

I actually have been using two (similar) review boilerplate/templates. After
some reviews and edits considering your suggestion, this is what I will
likely be going forward with:

For full reviews, et al.:

Theme Review:
- Themes should be reviewed using "define('WP_DEBUG', true);" in
wp-config.php
- Themes should be reviewed using the test data from the Theme Checklists
(TC)

--
WP_DEBUG et al.:

--
TC:

--
General Observations:

--
Overall: not-accepted
* Items marked => must be addressed, they are singificant and will most
likely
cause the theme to be not accepted.
* Items marked with -> are suggestions, but recommended to be addressed.
* Items marked with - are notes and observations.
* Other items noted should be addressed and corrected as needed.
* Additional review may be required once the above issues are resolved.

Again, this is not a complete review. The Theme may have other issues that
do
not meet the Theme Review Guidelines.
* Theme Review - http://codex.wordpress.org/Theme_Review
* Theme Unit Checklist - http://codex.wordpress.org/Theme_Unit_Test
* Theme Development - http://codex.wordpress.org/Theme_Development

Once the points above have been addressed appropriately using the available
information found at the links above; please thoroughly review your theme
and
re-submit it using the uploader tool:
http://wordpress.org/extend/themes/upload/
... this will generate a new Trac ticket.

NB: Re-submitted Themes are given review priority over new Themes that have
not
been reviewed yet.

Also note, to preserve your queue position if you upload a new revision to
the
theme before the current Trac ticket has been resolved:
1. Note the "new" ticket number of the revision.
2. Go to the oldest *open* ticket for your theme.
3. Add a comment to the *open* ticket with a link to the "new" ticket.
4. The next review should take this into consideration.

Feel free to make use of the contact details below if you have any
questions,
comments, or feedback:
* Leave a comment on this ticket
* Send an email to the Theme Review email list
* Use the #wp-themes IRC channel on Freenode

----
Test Environment:
WP Theme Reviews by Cais
* WordPress Version: 3.0.1
* PHP version: 5.2.13
* Multisite Enabled: False
* Current User Level: 10

For Quick Review Results (as a comment after using Pross' Theme Check
script):

Theme Quick Review:
- Themes should be reviewed using "define('WP_DEBUG', true);" in
wp-config.php
- Themes should be reviewed using the test data from the Theme Checklists
(TC)

For expediency sake, please review the above points noted in the "Quick
Review
Results" and address those immediately.

Again, this is not a complete review. The Theme may have other issues that
do
not meet the Theme Review Guidelines.
* Theme Review - http://codex.wordpress.org/Theme_Review
* Theme Unit Checklist - http://codex.wordpress.org/Theme_Unit_Test
* Theme Development - http://codex.wordpress.org/Theme_Development

Once the points above have been addressed appropriately using the available
information found at the links above; please thoroughly review your theme
and
re-submit it using the uploader tool:
http://wordpress.org/extend/themes/upload/
... this will generate a new Trac ticket.

NB: Re-submitted Themes are given review priority over new Themes that have
not
been reviewed yet.

Also note, to preserve your queue position if you upload a new revision to
the
theme before the current Trac ticket has been resolved:
1. Note the "new" ticket number of the revision.
2. Go to the oldest *open* ticket for your theme.
3. Add a comment to the *open* ticket with a link to the "new" ticket.
4. The next review should take this into consideration.

Feel free to make use of the contact details below if you have any
questions,
comments, or feedback:
* Leave a comment on this ticket
* Send an email to the Theme Review email list
* Use the #wp-themes IRC channel on Freenode

Thoughts?

Cais.

On Tue, Sep 28, 2010 at 2:38 PM, Edward Caissie <edward.caissie at gmail.com>wrote:

> Yes, I have been reviewing and editing my ending "boilerplate" text
> regarding comments legend, general overview, and WPTRT contact points ... I
> agree something explaining the meaning of a closed ticket would be helpful
> for those not used to the Theme TRAC process.
>
>
> Cais.
>
>
>
> On Tue, Sep 28, 2010 at 2:24 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> Cais,
>>
>> This is certainly a potential disconnect between users of Core-Trac and
>> Theme-Trac. Closing a ticket on Theme-Trac means a completely different
>> thing than closing a ticket on Core-Trac. With Core-Trac, closing a ticket
>> basically means the change doesn't get implemented. So, anyone used to
>> working with Core-Trac would likely interpret a closed ticket in Theme-Trac
>> as meaning that a Theme won't be considered.
>>
>> It might be helpful to put wording similar to this in the ticket comment:
>>
>> *Responding To This Review*
>>
>> Theme cannot be accepted until items listed under *Required* are
>> addressed. Once these issues have been resolved, please re-submit your Theme
>> using the uploader tool on wordpress.org/extend/themes, and a new Trac
>> ticket will be generated. Re-submitted Themes are given review priority over
>> new Themes.
>>
>> Chip
>>
>> On Tue, Sep 28, 2010 at 1:14 PM, Edward Caissie <edward.caissie at gmail.com
>> > wrote:
>>
>>> A new ticket will be created when you upload the next revision.
>>>
>>>
>>> Cais.
>>>
>>>
>>> On Tue, Sep 28, 2010 at 2:11 PM, Abdussamad Abdurrazzaq <
>>> abdussamad at abdussamad.com> wrote:
>>>
>>>>  On 28/09/2010 6:23 PM, theme-reviewers at lists.wordpress.org wrote:
>>>>
>>>>> Feedback for the Blacklens theme is at
>>>>> http://themes.trac.wordpress.org/ticket/1047
>>>>>
>>>>> --
>>>>> The WordPress.org Themes Team
>>>>> theme-reviewers at lists.wordpress.org
>>>>>
>>>>>  Please reopen this ticket. I do intend to fix the problems in the
>>>> blacklens theme and submit an updated version.
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100928/fc9a037d/attachment-0001.htm>