[theme-reviewers] get_option('home') bloginfo('url') and home_url()

Edward Caissie edward.caissie at gmail.com
Wed Sep 15 17:38:44 UTC 2010


Theme Review page update required ...

On Wed, Sep 15, 2010 at 12:53 PM, Andrew Nacin <wp at andrewnacin.com> wrote:

> ... I would strongly recommend that avoiding get_option('home') should be
> *required*. If a theme does it, tell them not to. I'm not concerned about
> rejecting said theme as much as making it crystal clear that while
> home_url() is recommended over both get_bloginfo('url') and
> get_option('home'), that there are different reasons for each.
>
> get_bloginfo('url') simply calls home_url(). They can be treated as
> synonymous and the guidelines might as well say "home_url() or
> get_bloginfo('url')", without stating a preference. (Various other
> get_bloginfo() calls are synonymous with independent functions.)
>
> But the same cannot be said for get_option('home'). The issue here being
> that get_option('home') simply cannot properly support SSL situations. Thus
> get_option('home') is a bad idea.
>

The above idea needs to be added to the Theme Review page / Knowledge
Base(?) ... add something like "Strongly Recommended" to use home_url() in
place of get_option("home") with the expectation get_option("home") will not
be used in future theme updates if home_url() can be used in its place ... a
little verbose but that's the general idea.


Cais.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100915/bd1eef3f/attachment.htm>


More information about the theme-reviewers mailing list