[theme-reviewers] wp_enqueue_script

Chip Bennett chip at chipbennett.net
Wed Sep 15 14:49:31 UTC 2010


For the Theme in question, it's wrapped in the usual conditionals (e.g. *if
( is_singular() && get_option( 'thread_comments' ) )* ). It's just not
hooked into anything. I'll make the suggestion to hook into wp_head().

Thanks!

Chip

On Wed, Sep 15, 2010 at 9:42 AM, Andrew Nacin <wp at andrewnacin.com> wrote:

> On Wed, Sep 15, 2010 at 10:37 AM, Chip Bennett <chip at chipbennett.net>
>  wrote:
>
> When adding wp_enqueue_script( 'comment-reply' ) via functions.php, doesn't
>> this function call need to be hooked into wp_head()?
>
>
> If it's going via functions.php, yeah, it should be attached to a hook. Any
> theme that has code bouncing around in functions.php needs careful auditing
> just to see whether it's doing anything it should be waiting on.
>
> For the specifics of comment-reply, they should only be enqueueing it on
> pages they need it. An is_singular() check, I'd say.
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100915/a662e1fe/attachment.htm>


More information about the theme-reviewers mailing list