[theme-reviewers] My First Suggest-Approval *sniff*

[Chip Bennett]

So, you're single, greatest complaint with the guidelines is that we require
no deprecated WP function calls, and no PHP errors?

I am *absolutely* against allowing deprecated function calls, unless no
alternative exists.

As for PHP errors: they're usually just indicative of overall code quality.
I have yet to review a Theme that failed merely for PHP errors (or
deprecated WP function calls). If we start seeing such Themes, then it would
be worth another look. Besides, most PHP errors are either undeclared
variables, or improperly called strings in function arguments. Both are
easily correctable, and doing so isn't overly burdensome on Theme
developers.

Chip

On Sun, Sep 12, 2010 at 1:09 PM, Andrew Nacin <wp at andrewnacin.com> wrote:

> On Sun, Sep 12, 2010 at 1:20 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> Do you have *specific* examples of onerous or unnecessary review
>> requirements? Quite honestly, the review queue remains steady at 60+ Themes.
>> We don't have time for navel-gazing.  But if there are *specific*
>> requirements that need to be addressed, we're always up for looking at them.
>> (I've actually got a couple to bring up myself, regarding the Theme Unit
>> Tests.)
>>
>
> Yes. I've said previously on this list (in an email that received no
> replies) that I do not believe that themes should be rejected for notices
> and deprecated calls. This is coming from the individual who implemented
> deprecated argument handling, spent dozens of hours tracking down version
> numbers for deprecated functions, preaches WP_DEBUG [0, 1, 2], and wrote the
> logging plugin you use.
>
> [0] http://www.andrewnacin.com/tag/wp_debug/
> [1] http://core.trac.wordpress.org/changeset/13176
> [2] http://core.trac.wordpress.org/changeset/13185
>
> That's not to say that theme authors shouldn't be encouraged to rectify
> notices on future theme submissions, or that the tolerance level shouldn't
> go down on successive submissions by that author. But it all depends on the
> notice, and it all depends on the deprecated call. If notices and deprecated
> calls cannot be properly evaluated for severity, then they should not be
> evaluated at all.
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100912/7f1ab84a/attachment.htm>