[theme-reviewers] Themes With Customizable Logos

[Chip Bennett]

Still working on the review. Ticket is
#915<https://themes.trac.wordpress.org/ticket/915>
.

I actually use the core functionality to update the header image, that is
applied via CSS.

Basically, I use the core functionality as a nice UX upload-preview-change
tool. The image itself gets applied as a CSS background. :)

Chip

On Thu, Sep 2, 2010 at 10:22 AM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

>  Yes, that can be done definately in a better way and the custom-header
> would be a good route, got a ticket # ? anyways, look at the header.php if
> its a hardcoded image that absofricken lutely
>
> Personally I *hate* the custom-header code., Literally.  Easier and more
> control with your own CSS.
>
> - Phil
>
> heh, i'm *never* going to support custom-header, so guess i'm out of the
> repository; as I said CSS of your own is a much more controlled route, what
> I did with CP is I made it an option to use it or not in the addons - theme
> options to use or not ;/
>
>
> ----- Original Message -----
> *From:* Chip Bennett <chip at chipbennett.net>
> *To:* theme-reviewers at lists.wordpress.org
> *Sent:* Thursday, September 02, 2010 8:12 AM
> *Subject:* Re: [theme-reviewers] Themes With Customizable Logos
>
> In this particular Theme, the documentation basically says, "A logo.psd
> and independence.ttf is included in the psd folder. Edit the psd file, save
> as logo.gif and upload to the images folder".
>
> At a minimum, it's a *recommend *with respect to Custom Image Header
> functionality. I'm leaning toward *require*.
>
> Chip
>
> On Thu, Sep 2, 2010 at 10:09 AM, Philip M. Hofer (Frumph) <
> philip at frumph.net> wrote:
>
>>  If it's based in CSS I would think not, if its an <img then I would say
>> absolutely.  CSS is very easy to manipulate, while editing core files should
>> make it so that it would be the responsible thing a theme developer should
>> provide the custom-header instead of hardcoding.
>>
>> - Phil
>>
>>   ----- Original Message -----
>> *From:* Chip Bennett <chip at chipbennett.net>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Thursday, September 02, 2010 8:06 AM
>> *Subject:* [theme-reviewers] Themes With Customizable Logos
>>
>> For Themes that have header logos that are customizable, should we be
>> requiring that implementation to support the core Custom Header Image
>> functionality?
>>
>> Reference this wording from the Guidelines:
>>
>>  Theme is *recommended* to incorporate the following WordPress core
>> functionality, but is *not required* to do so. However, if incorporated,
>> functionality must support the core WordPress implementation:
>>
>>  ...
>>
>>  Custom Header:
>> ...
>>
>>
>> Thoughts?
>>
>> Chip
>>
>> ------------------------------
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>  ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100902/74ec70b3/attachment-0001.htm>