[theme-reviewers] searchform.php

[Rodrigo Galindez]

Hi Nacin,

Thanks for this message. Sorry, it was my fault. After closing the
ticket I read a bit more about get_search_form() in the Codex.

I'm going to add a comment in the ticket that hopefully amends this.

Thanks!

Best,

Rod

On Wed, Sep 1, 2010 at 3:24 AM, Andrew Nacin <wp at andrewnacin.com> wrote:
> In a recent theme review I read:
>
>> searchform.php is included via a deprecated call in index.php,
>> sidebar.php,
> archive.php and searchform.php. Please use get_template_part().
> Whether including searchform.php directly via include() or require(), or
> indirectly via get_template_part() -- neither are preferred methods.
> For searchform.php, the proper function would be get_search_form().
> This function then looks for searchform.php, uses it if it exists, and uses
> a standard form if it doesn't.
> Often, a theme's searchform.php is nearly identical to the HTML that
> get_search_form() should generate. In this case, it would be easier if the
> theme simply removed the file. (Twenty Ten had one originally; we removed it
> before release.)
> Hope that helps,
> Nacin
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>



-- 
Interaction Designer
clarisapp.com | rodrigogalindez.com