[theme-reviewers] Themes and Post Meta/Custom Fields

[Edward Caissie]

Umm ... aside from a few other issues related to the Test Data that appears
to coming up at the moment, included with the Test Data are five (5!) custom
field keys:


   - email_notification
   - enclosure
   - geo_public (set to 0)
   - jabber_published
   - superawesome (set to false - twice!)

So, anyone else want to refresh their database and do a fresh import of the
test data?

Look for the above custom field keys ... and issues with the imported data
throwing notices on Twenty Ten, too!


Cais

PS: Use the following simplified method:
1) Go into phpMyAdmin ... drop the database.
2) Go to site ... re-install (using same database just dropped)
 3) Go to the Test Unit Data; download.
4) Import (importer works without re-activating?!)
 5) Edit the "Layout" test post ...
EAC


On Thu, Oct 21, 2010 at 12:27 PM, Gene Robinson <emhr at submersible.me> wrote:

> I think #3 would be best accomplished via a Theme's settings/options page.
> Even if a deactivation hook existed, I don't think i would want it to reset
> all of a themes options and custom settings without user consent.
>
> To some degree users who change themes and plugins often will always have
> cluttered options and postmeta. At least if the functionality and intention
> is well documented and the option is there to reset or delete settings when
> the theme is active, users who don't want to muck about with the database
> are empowered.
>
> -Gene
>
> On Oct 21, 2010, at 12:11 PM, Chip Bennett wrote:
>
> These are good guidelines.
>
> I think the ones that we can certainly implement as consistent with
> existing guidelines are #1 and #2.
>
> Any suggestion for such an automated way to remove such post meta data?
> (Yet *another* argument for a Theme deactivation/deletion hook.)
>
> Chip
>
> On Thu, Oct 21, 2010 at 11:05 AM, Gene Robinson <emhr at submersible.me>wrote:
>
>> I'm ok with the idea of themes adding post meta if they:
>> 1. document it's function and purpose in theme docs, read-me, and/or
>> options/settings page.
>> 2. prepend the post meta with the theme slug like identifier
>> 3. offer an automated way to remove the post meta should the user desire
>> removal or to reset it.
>>
>> -Gene
>>
>> On Oct 21, 2010, at 11:53 AM, Chip Bennett wrote:
>>
>> > I just ran into another one, thanks to a Theme that outputs all of a
>> post's custom field keys/values as post meta data: apparently, some Themes
>> are adding custom fields to posts.
>> >
>> > Should there be some guidance here? Specifically, should Themes be
>> adding meta information/custom field keys/values to existing posts without
>> user knowledge?
>> >
>> > In my case, one Theme added various default Thumbnail images as custom
>> fields, and another Theme added a "superawesome" custom field key (with a
>> value of "false").
>> >
>> > Chip
>> > _______________________________________________
>> > theme-reviewers mailing list
>> > theme-reviewers at lists.wordpress.org
>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101021/201a3600/attachment-0001.htm>