[theme-reviewers] Upload Pronto.zip failed?

[Joseph Scott]

The upload process only scans the .php files, binary files like the
.swf are skipped.

The XML declaration is a long standing known issue with PHP short
tags, one reason why they are recommended to be turned off.  However,
since we can't control the PHP setup of every server out there the
safest thing to do is break up the XML declaration so that <? do no
appear right next to each other.  Something like

    '<' . '?'

should work.

On Sat, Jul 24, 2010 at 10:36 AM, Simon Prosser <pross at pross.org.uk> wrote:
> pross at dhcppc1 ~/pronto $ grep -rn "<?[^p]" *
> Binary file cjl/pronto/uploadify/uploadify.allglyphs.swf matches
> Binary file cjl/pronto/uploadify/uploadify.swf matches
> cjl/pronto/design.php:429:      fwrite($fp,"<?xml version=\"1.0\"?>\n");
> Binary file images/pronto_box/Ponta-de-sao-lourenco.gif matches
> Binary file styles/icons/social/default/flickr.png matches
>
> We have seen this problem before, the uploader checks the files for "<?" and
> stops the upload if it sees it in any file, oyur package contains a few
> matches.
>
> Im not sure if Joseph changed the script to ignore binary files such as images,
> im afraid you may have to edit your code some how perhaps something like:
> $type = '?xml';
> fwrite($fp,"<$type version=\"1.0\"?>\n");



-- 
Joseph Scott
joseph at josephscott.org
http://josephscott.org/