[theme-reviewers] [WordPress Themes] #2311: THEME: tweaker2 -2.0.3

[Philip M. Hofer (Frumph)]

1) Layout test shows that on the layout test post itself, the floated left image floats to the left, then the Pages: 1 2 3 are to the right of this, that denotes that the_content() isn't being cleared of whatever is floating inside of it.

2) License URI at this time is just recommendation but thanks for adding it. (until 3.1 is released)

3) The "no comments" when comments are disabled on pages can be handled code wise so that they do not display, there are several ways of doing it, especially with if (is_page()) sort of thing.

I do something like this:

if ('open' == $post->comment_status) {

comments_template('', true);

}

which works for me, so find one that works for you so the message doesn't display on pages.





  ----- Original Message ----- 
  From: Arnold Goodway 
  To: theme-reviewers at lists.wordpress.org 
  Sent: Friday, December 17, 2010 9:45 PM
  Subject: Re: [theme-reviewers] [WordPress Themes] #2311: THEME: tweaker2 -2.0.3


  Hi,

  Thanks for taking the time to review the update to my theme. I am however slightly confused as to the reasons given as to why the theme has not been approved.

  The License URI was not in the stylesheet but a license.txt has been included in the theme. In my re-submission I have added a License URI.

  The "no comments here" shown on a page with the comments disabled does not come from the theme. These words are part of the content of the 'Page With Comments Disabled' in the theme unit test.

  "Layout Test with the theme unit tests reveals that the_content() isn't  getting the floats cleared after it displays text or image that is floated inside of it.  Appears to be relevant to the single.php display of the sticky post." Here I will need more clarification. This all works the way it is supposed to from my side. Even in IE6 the floats are clearing properly.

  Thanks.

  Arnold.






  On Fri, Dec 17, 2010 at 8:50 PM, WordPress Themes <theme-reviewers at lists.wordpress.org> wrote:

    #2311: THEME: tweaker2 - 2.0.3
    ----------------------------+----------------------------
     Reporter:  ArnoldGoodway  |     Owner:  Frumph
         Type:  theme          |    Status:  assigned
    Resolution:                 |  Keywords:  theme-tweaker2,
    ----------------------------+----------------------------


    Comment (by Frumph):

     / License URI: will be a requirement as well as the License: in the
     style.css w/3.1 so for now just recommendation

     => Layout Test with the theme unit tests reveals that the_content() isn't
     getting the floats cleared after it displays text or image that is floated
     inside of it.  Appears to be relevant to the single.php display of the
     sticky post.

     => pages that have comments disable shouldn't display "No comments here."
     posts sure, but not pages.
     http://codex.wordpress.org/Theme_Unit_Test#Page_With_Comments_Disabled

     / - Suggestion
     - notes
     => required

     Please test your theme with the theme unit test.
     http://codex.wordpress.org/Theme_Unit_Test

    --
    Ticket URL: <http://themes.trac.wordpress.org/ticket/2311#comment:2>

    WordPress Themes <http://themes.trac.wordpress.org/>
    WordPress.org Theme Directory Reviews




------------------------------------------------------------------------------


  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101218/42f01fee/attachment.htm>