[theme-reviewers] [WordPress Themes]

Thu Dec 16 21:48:11 UTC 2010

Okay, how does this look? 

http://themes.trac.wordpress.org/ticket/2111#comment:2

Jay

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Furcifer
Sent: 16 December 2010 20:59
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Thanks Chip, I think this theme is defaulted to German or something, with no
translation files in the language dir, There are a couple of other issues I
can see outright, I'll leave a comment on the ticket.

Jay

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Chip
Bennett
Sent: 16 December 2010 20:55
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Yes!

English default text strings, with translation files for any other language.

Chip

On Thu, Dec 16, 2010 at 2:48 PM, Furcifer <furcifer at furcifer.net> wrote:

Cheers Cais, just one question, themes hosted on WordPress. Do they gotta be
English? lol

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 20:39

To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

OK, have a run at th is one: http://themes.trac.wordpress.org/ticket/2111

On Thu, Dec 16, 2010 at 3:26 PM, Furcifer <furcifer at furcifer.net> wrote:

Comment submitted, got another? lol

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 20:25

To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Thanks. It's built based on the client's mock-up, I just manipulated Twenty
Ten to fit ... I'll be keeping a copy of the template files for future
reference as the theme uses 'front-page.php' which is not found in the
default Twenty Ten theme.

On Thu, Dec 16, 2010 at 3:17 PM, Furcifer <furcifer at furcifer.net> wrote:

[ there must be a significant difference in design and/or functionality for
it to be considered a unique theme and not a child of the original parent.]

Plagiarised: ~Grin~ Thanks guys.

Damn Cais, that's a nice looking theme

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 20:10

To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Although Twenty Ten is getting most of the parent-child attention of late,
essentially what Phil is saying is the case ...

I generally use wording along the lines: there must be a significant
difference in design and/or functionality for it to be considered a unique
theme and not a child of the original parent.

Here is an unreleased example of design difference, although the theme
itself was commissioned, but due to budgetary constraints was not completed
I would consider it different enough (visually, at least) in design to be
considered as its own theme.

http://mvbi.edwardcaissie.com/

I'll be dismantling this test site soon ... but feel free to have a look.

Cais.

On Thu, Dec 16, 2010 at 2:55 PM, Philip M. Hofer (Frumph)
<philip at frumph.net> wrote:

The old rule of thumb about the rips of twenty-ten used to be that just
changing the text-domain was not enough, that it had to offer something
different that twentyten did not, the header menubar/header piece at the top
really doesn't cut it.

As for the header image/text, they could respond that its 'by design' and
really there's nothing you can say about it other then 'recommending' it be
larger, but definately not a reason to fail the theme.

So if the theme itself doesn't have anything new to add to its pretty much
the twenty ten theme, thats sufficient enough to not-approve it,  respond
back Cais if this is still the case?

----- Original Message ----- 

From: Furcifer <mailto:furcifer at furcifer.net>  

To: theme-reviewers at lists.wordpress.org 

Sent: Thursday, December 16, 2010 11:49 AM

Subject: Re: [theme-reviewers] [WordPress Themes]

I'm gonna suggest is be not approved until that header is fixed, it's not
really just the menu, the header image is set far too small as well, I'm
guessing they didn't use the standard  test data and that they were probably
using a screen with a low res.

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 19:45
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Moving the menu in Twenty Ten can offer some challenges ... 

On Thu, Dec 16, 2010 at 2:43 PM, Furcifer <furcifer at furcifer.net> wrote:

Yeah I was thinking that to

From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 19:31

To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes]

Just a quick look (via SVN) at the header.php template file makes me think
this is a Twenty-ten child-theme ...

Cais.

On Thu, Dec 16, 2010 at 2:24 PM, Furcifer <furcifer at furcifer.net> wrote:

The new one that is, not the Typo theme >.<

-----Original Message-----
From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward
Caissie
Sent: 16 December 2010 15:20
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes] #2131: THEME:
Typo-o-graphy - 3.0.2

No worries. That's why we work through the first ones together. Even
long time reviewers still miss things, too.

Sent from my iPhone

On Dec 16, 2010, at 10:18 AM, Furcifer <furcifer at furcifer.net> wrote:

> @Cais damn I missed a few things, I apologise.
>
> -----Original Message-----
> From: WordPress Themes <theme-reviewers at lists.wordpress.org>
> Sent: Thursday, December 16, 2010 2:49 PM
> Subject: Re: [WordPress Themes] #2131: THEME: Typo-o-graphy - 3.0.2
>
> #2131: THEME: Typo-o-graphy - 3.0.2
> ---------------------+---------------------------------
>  Reporter:  tommek  |     Owner:  FurciferRising
>      Type:  theme   |    Status:  assigned
> Resolution:          |  Keywords:  theme-typo-o-graphy,
> ---------------------+---------------------------------
>
> Comment (by cais):
>
> => all (unique) theme functions should be appropriately prefixed with a
> consistent 'namespace' such as 'typo_' to avoid possible conflicts; see
> 'menu_args()' and 'add_my_stylesheet()' as examples (there are more to be
> addressed).
> -> index.html is does not need to be included with theme
> -> The 'add_editor_style()' function was called but the default 'editor-
> style.css' related file was not found. This should be addressed with the
> next update.
>
> Overall: not-approved
> * Items marked => must be addressed, they are singificant and will most
> likely cause the theme to be not accepted.
> * Items marked with -> are suggestions, but recommended to be addressed.
> * Items marked with - are notes and observations.
> * Other items noted should be addressed and corrected as needed.
> * Additional review may be required once the above issues are resolved.
>
> --
> Ticket URL: <http://themes.trac.wordpress.org/ticket/2131#comment:3>
> WordPress Themes <http://themes.trac.wordpress.org/>
> WordPress.org Theme Directory Reviews
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

  _____  

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101216/76561aea/attachment-0001.htm>