[theme-reviewers] Mini-Site Theme query_posts use

Chip Bennett chip at chipbennett.net
Mon Aug 30 15:01:18 UTC 2010


Feel free to add a comment on the ticket after I finish my review. I'll
leave you a place-holder. You can explain it better than I can. :)

Chip

On Mon, Aug 30, 2010 at 9:59 AM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

>  Nevermind I see it, header.php has
>
> //The Query
> query_posts('posts_per_page=10');
>
> Which basically overrides any common loop that occures then does a wp_reset_query(), he should be protecting that loops $wp_query and restarting the old wp_query after that loop of links happens.
>
> $temp_wp_query = $wp_query;
>
> <code>
>
> $wp_query = temp_wp_query;
>
> sort of thing.
>
> *or* not use query_posts and creates a new WP_Query which is the better way of handling that.
>
>  ----- Original Message -----
> *From:* Chip Bennett <chip at chipbennett.net>
> *To:* theme-reviewers at lists.wordpress.org
> *Sent:* Monday, August 30, 2010 7:50 AM
> *Subject:* [theme-reviewers] Mini-Site Theme query_posts use
>
> Can someone take a look at the MiniSite Theme<https://themes.trac.wordpress.org/ticket/862>for me? It's making a ton of query_posts() calls. I'm wondering if they're
> really necessary?
>
> Chip
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100830/1aab1155/attachment.htm>


More information about the theme-reviewers mailing list