[theme-reviewers] Nevermind

[Safirul Alredha]

I would failed this because:

1) The theme author probably copy paste or based on i18n kubrick /
default with style change or with some additional template. When this
happen if there's any additional string, the new string obviously not
included in POT file.
2) text domain should be unique (I know there's somewhere in codex
that stated this).
3) There are some cases where the theme had 2 text domain as a result
from copy paste or based from 2 - 3 different theme.

So if the theme author is serious about making the theme
translation-ready, this is "important".

On Thu, Aug 12, 2010 at 7:30 PM, Edward Caissie
<edward.caissie at gmail.com> wrote:
> Changing the text domain is simply find and replace ... it should be
> addressed if there are any other issues that cause the theme to be
> "not-accepted", otherwise if all else is good then a notation to fix by the
> next release would be fine.
>
> Just my opinion on something easy to fix like that.
>
>
> Cais
>
> On Thu, Aug 12, 2010 at 3:02 AM, Philip M. Hofer (Frumph)
> <philip at frumph.net> wrote:
>>
>> heh it's all good, basically when i'm typing things into the box and you
>> post something, it then fails letting me post the review ;/  havent had that
>> happen before so it messed with me, oh yeah I know about the text-domain but
>> it's not a must-change since the main core theme doesnt use kubrik anywhere
>> (anymore)  so that wouldn't fail the theme's review, just notation for
>> suggestion of replacing imo.
>>
>> - Phil
>>
>> ----- Original Message ----- From: "Safirul Alredha" <zeo at zeo.my>
>> To: <theme-reviewers at lists.wordpress.org>
>> Sent: Wednesday, August 11, 2010 11:48 PM
>> Subject: [theme-reviewers] Nevermind
>>
>>
>> :-P
>>
>> My bad. Sorry about that. I was picking the simplest theme in queue to
>> review (now that there's less BP theme on top). Forgot to assign to
>> myself.
>>
>> On Thu, Aug 12, 2010 at 2:39 PM, Philip M. Hofer (Frumph)
>> <philip at frumph.net> wrote:
>>>
>>> It appears Zeo jumped on my assigned ticket, it's all good. They just
>>> need
>>> to make sure not to snag an assigned ticket.
>>>
>>> - Phil
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>