[theme-reviewers] Question regarding Theme Unit Test

[Edward Caissie]

I prefer 'overflow: hidden;' too, but using 'max-width' should work
correctly as well.


Cais

On Thu, Aug 12, 2010 at 4:11 PM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

>  I was informed of this by Cais just a few minutes ago.
>
> - Phil
>
> My prefered is overflow: hidden; personally.
>
> ----- Original Message -----
> *From:* Chip Bennett <chip at chipbennett.net>
> *To:* theme-reviewers at lists.wordpress.org
> *Cc:* Sayontan Sinha <sayontan at gmail.com> ; Philip M. Hofer (Frumph)<philip at frumph.net>
> *Sent:* Thursday, August 12, 2010 1:07 PM
> *Subject:* Re: [theme-reviewers] Question regarding Theme Unit Test
>
> I disagree with this point:
>
>   you can't use
>>
>> img { max-width: #;  }
>>
>> in the post-content area is basically what's that saying, (which is what
>> is done usually)  the huge image in the image test that's in side of there
>> should be handled with overflow:
>>
>> and the $content_width is for the post area content width to handle the
>> sizing, which is how wordpress takes care of that issue
>>
>
> There's nothing wrong with a Theme defining max-width for images via CSS.
>
> Rather, what those tests verify is that, if max-width *isn't* defined for
> images, that the overflow is handled aesthetically.
>
> Personally, I would say that defining max-width is the *preferred* means of
> handling over-sized images.
>
>
>> Hello,
>> I have a question regarding the Theme Unit Test for images. The test says:
>>
>>
>>    - Wide Image (Resized) Test
>>       - Image should display properly, and should be resized as
>>       specified.
>>       - Sidebar must not be pushed to the bottom of the page.
>>    - Wide Image (Not Resized) Test
>>       - Wide image overflows properly (using max-width CSS rule or
>>       content_width value is defined).
>>       - Sidebar must not be pushed below content due to image overlap.
>>
>> I am not very clear on the distinction here. Does it mean that images
>> should not be automatically resized to fit the width of the posts?
>>
>>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100812/5666ff56/attachment.htm>