[theme-reviewers] [WordPress Themes] Suffusion, new version 3.6.2
Sayontan Sinha
sayontan at gmail.com
Mon Aug 9 17:38:23 UTC 2010
>
> Comicpress's screenshot contains an image inside the screenshot based on
> the users input. The rest is exact. Your theme however defaults as a black
> set of themes.
Wonderful. Yes, Suffusion, *defaults* as a black set of themes, but all you
need to do is switch the theme to Minima and you will get the white look
(user input, as you call it). Now switch to the magazine layout and you will
get the exact layout that you see in the screenshot (again, user input).
Additionally, it's my suggestion that you make your theme into a framework
> and utilize child themes instead of containing the various different looks
> from within it.
>
Thanks. Suffusion is already a framework where you can build child themes,
FYI. I myself use a child theme, as do quite a few users.
On Mon, Aug 9, 2010 at 10:28 AM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:
> 1) Comicpress's screenshot contains an image inside the screenshot based
> on the users input. The rest is exact. Your theme however defaults as a
> black set of themes.
>
> Additionally, it's my suggestion that you make your theme into a framework
> and utilize child themes instead of containing the various different looks
> from within it.
>
> 2) functions.php
>
> if (function_exists('wp_nav_menu')) {
>
> if (*$menus_style* *==* 'rolled-up') {
>
> foreach (*$menus_included* as *$menu*) {
>
> if (*$menu->*term_id *==* intval(substr(*$entity*, 5)) *&&* *!*in_array(*
> $menu->*term_id, *$processed_menus*)) {
>
> *$processed_menus*[] *=* *$menu->*term_id;
>
> *$menu_items* *=* wp_get_nav_menu_items(*$menu->*term_id);
>
> *$menu_structure* *=* suffusion_get_menu_structure(0, *$menu->*name, null,
> 1, *$menu_items*, 'menu');
>
> *$nav_structure->*children[] *=* *$menu_structure*;
>
> }
>
> }
>
> }
>
> Oh . look.. wp_get_nav_menu_items! Just register the nav menu's already.
>
> 3. Would you like me to do a full code review? Let's start with optimizing
> your theme, it currently adds a 27% addition to the processor load per
> user per page load and a 3M increase per page load in comparison to other
> themes. Memory tops at 32M overall usage, which is at cap for most shared
> hosting. I recommend rewriting for optimization and maybe looking into
> useing wp_cache_set for global information.
>
>
>
> ----- Original Message -----
> *From:* Sayontan Sinha <sayontan at gmail.com>
> *To:* Philip M. Hofer (Frumph) <philip at frumph.net>
> *Cc:* theme-reviewers at lists.wordpress.org
> *Sent:* Monday, August 09, 2010 10:23 AM
> *Subject:* Re: [theme-reviewers] [WordPress Themes] Suffusion,new version
> 3.6.2
>
> Phil,
>
> 1. I did check the last theme that was approved - ComicPress. When
> activated the screenshot is very different from what you see in
> screenshot.png. Obviously different standards are being applied to different
> themes.
> 2. If you search through the code, you will NOT see wp_nav_menu() being
> used anywhere. Only the existence of the function is being checked - the
> function itself is not being used. What do you want me to register?
> 3. Read my email carefully. I said the review is not thorough and I
> didn't suggest you are testers. I understand you are in testing overdrive,
> but your comments come off sounding pedantic at the least.
>
> Sayontan.
>
> On Mon, Aug 9, 2010 at 10:10 AM, Philip M. Hofer (Frumph) <
> philip at frumph.net> wrote:
>
>> 1) If the screenshot.png does not look like what the end user see's when
>> activating the theme, the screenshot.png is invalid.
>>
>> 2) However if you USE wp_nav_menu(); then you MUST register it., you use
>> it, register it.
>>
>> 3) Line 288 in actions.php is not wrapped around conditional <!-- if
>> statements which should be used as an enqueue
>>
>> 4) We're not your theme testers, we're reviewers, test your theme before
>> submitting.
>>
>> - Phil
>>
>> ----- Original Message -----
>> *From:* Sayontan Sinha <sayontan at gmail.com>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Monday, August 09, 2010 9:54 AM
>> *Subject:* Re: [theme-reviewers] [WordPress Themes] Suffusion,new version
>> 3.6.2
>>
>> Hello,
>> I have been following the feedback posted for this version of the theme
>> and I believe the review is inaccurate and not thorough. Here is what was
>> posted:
>>
>>>
>>> 1.
>>>
>>> screenshot.png does not look like the theme's output.
>>> 2.
>>>
>>> wp_nav_menu(); being used but registration of available locations not
>>> being set
>>> 3.
>>>
>>> all scripts and styles should be enqueued ref: actions.php line 288,
>>> line 427-429 suffusion-options-page.php and various other locations, unless
>>> otherwise inapplicable to make the code work properly, i.e. <!-- IF
>>> statements
>>>
>>> Point #1 is incorrect. You get that with the Magazine template (bundled
>> with the theme, Templates -> Magazine in the options page) and the Minima
>> skin (Visual Effects -> Theme Selection, WITHOUT changing any code.
>>
>> Point #2: The use of wp_nav_menu() is recommended, not mandatory, as per
>> the Theme Review checklist:
>>
>>> Themes are strongly suggested to support the following customization
>>> features:
>>>
>>> - Custom Menu - wp_nav_menu()<http://codex.wordpress.org/Function_Reference/wp_nav_menu>
>>> - If a navigation menu is part of the Theme's design, it should be
>>> a customizable menu. For Themes that do not have a navigation menu, users
>>> should be able to add a Custom Menu widget.
>>>
>>> If you define a custom WP 3.0 menu you can include it in the navigation
>> bars from the settings in Blog Features -> Main Navigation Bar Setup or Blog
>> Features -> Top Navigation Bar Setup. If you do not define a native WP menu
>> you can still build your menus from the Navigation bar Setup pages in the
>> options. I don't see how this is grounds for rejection.
>>
>> Point #3: The scripts and styles are enqueued where applicable. The line
>> #288 in actions.php that has been listed is a conditional include, and the
>> lines 427-429 in suffusion-options-page.php are for scripts in the admin
>> page, not in the theme itself. The stylesheets cannot be enqueued because
>> there is a custom-styles.php file that is printed out, and enqueuing
>> destroys the sequence for that.
>>
>> IMHO, the review is not thorough enough.
>>
>> Sayontan.
>>
>> On Sat, Aug 7, 2010 at 10:26 AM, <theme-reviewers at lists.wordpress.org>wrote:
>>
>>> Thank you for uploading version 3.6.2 of Suffusion.
>>>
>>> Feedback will be provided at http://themes.trac.wordpress.org/ticket/604
>>>
>>> --
>>> The WordPress.org Themes Team
>>> theme-reviewers at lists.wordpress.org
>>>
>>
>>
>>
>> --
>> Sayontan Sinha
>> http://mynethome.net | http://mynethome.net/blog
>> --
>> Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
>> American name for Lake Webster, Webster, Massachusetts, meaning "You fish on
>> your side; I fish on my side; nobody fish in the middle."
>>
>> ------------------------------
>>
>> _______________________________________________
>> theme-reviewers mailing list
>>
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> --
> Sayontan Sinha
> http://mynethome.net | http://mynethome.net/blog
> --
> Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
> American name for Lake Webster, Webster, Massachusetts, meaning "You fish on
> your side; I fish on my side; nobody fish in the middle."
>
>
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
American name for Lake Webster, Webster, Massachusetts, meaning "You fish on
your side; I fish on my side; nobody fish in the middle."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100809/a6d8283e/attachment.htm>
More information about the theme-reviewers
mailing list