[theme-reviewers] [WordPress Themes] Suffusion - feedback
Philip M. Hofer (Frumph)
philip at frumph.net
Sat Aug 7 03:56:39 UTC 2010
Hah, nice one, totally misread that because I was looking for the forms.
go go legacy checks!
- Phil
So the only thing you need then is to make that disabled message as the default on is_page and you're set
----- Original Message -----
From: Sayontan Sinha
To: Philip M. Hofer (Frumph)
Cc: theme-reviewers at lists.wordpress.org
Sent: Friday, August 06, 2010 8:53 PM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion - feedback
Are you sure you are seeing the right files? Lines 51 to 84:
if (function_exists('comment_form')) {
comment_form(array(
'fields' => array(
'author' => "
<p>
<label for='author' class='$label_style'>$suf_comment_label_name</label>
<input type='text' name='author' id='author' class='textarea' value='".esc_attr($comment_author)."' size='28' tabindex='1' />". ($req ? $suf_comment_label_name_req : "")."
</p>",
'email' => "
<p>
<label for='email' class='$label_style'>$suf_comment_label_email</label>
<input type='text' name='email' id='email' value='".esc_attr($comment_author_email)."' size='28' tabindex='2' class='textarea' />". ($req ? $suf_comment_label_email_req : ""). "
</p>",
'url' => "
<p>
<label for='url' class='$label_style'>$suf_comment_label_uri</label>
<input type='text' name='url' id='url' value='".esc_attr($comment_author_url)."' size='28' tabindex='3' class='textarea' />
</p>"
),
'comment_field' => "
<p>
<label for='comment' class='textarea $label_style'>$suf_comment_label_your_comment</label>
<textarea name='comment' id='comment' cols='60' rows='10' tabindex='4' class='textarea'></textarea>
</p>",
'logged_in_as' => '<p class="logged-in-as">'.sprintf(__('Logged in as %s. ', 'suf_theme'), "<a href='".admin_url('profile.php')."'>".$user_identity."</a>").
' <a href="'.wp_logout_url(apply_filters('the_permalink', get_permalink($post_id))).'">'.__('Log out', 'suf_theme').'</a>.'.'</p>',
'must_log_in' => '<p class="must-log-in">'.
'<a href="'.wp_login_url(apply_filters('the_permalink', get_permalink($post_id))).'">'.__('You must be logged in to post a comment.', 'suf_theme').'</a></p>',
'title_reply' => __('Leave a Reply', "suf_theme"),
'title_reply_to' => __('Leave a Reply to %s', "suf_theme"),
'label_submit' => __('Submit Comment', "suf_theme"),
'comment_notes_before' => "<span></span>",
'comment_notes_after' => '<p class="form-allowed-tags">'.sprintf(__('You may use these <abbr title="HyperText Markup Language">HTML</abbr> tags and attributes: %s', 'suf_theme'), '<code>'.allowed_tags().'</code>').'</p>',
'cancel_reply_link' => __('Cancel reply', 'suf_theme'),
));
}
On Fri, Aug 6, 2010 at 8:52 PM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:
I'm looking at comments.php right now, and comment_form(); is not being used
specifically line 110 to line 132 is a written out form, when it should be using comment_form();
- Phil
----- Original Message -----
From: Sayontan Sinha
To: Philip M. Hofer (Frumph)
Cc: theme-reviewers at lists.wordpress.org
Sent: Friday, August 06, 2010 8:51 PM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion - feedback
Philip,
Not sure if you are seeing the right files. I do use comment_form.
Sayontan.
On Fri, Aug 6, 2010 at 8:44 PM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:
Coincidently need to use comment_form(); in comments.php now, I would fail this if you resubmitted it again without that change, if you could get that done before resubmitting, it wont take long for the next resubmit to get done there are more people now reviewing the themes, also if you're interested you can help review themes to get them done faster so the wait doesnt take so long as well, that's what i'm doing.
Also *if* you do use a filter to filter out the comments disabled messages on is_page(); you should have it set as a default that way.
- Phil
----- Original Message -----
From: Sayontan Sinha
To: theme-reviewers at lists.wordpress.org
Sent: Friday, August 06, 2010 7:35 PM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion - feedback
Hello,
Regarding the feedback, I checked the review checklist that says 'No "Comments Disabled" message should be displayed.' There is an option in the theme to hide the message. You can go to Blog Features -> Comment Settings and pick where you want the message to show and where you don't. Can I request reconsideration of the theme, given this information?
Thanks,
Sayontan.
On Fri, Aug 6, 2010 at 7:28 PM, <theme-reviewers at lists.wordpress.org> wrote:
Feedback for the Suffusion theme is at http://themes.trac.wordpress.org/ticket/589
--
The WordPress.org Themes Team
theme-reviewers at lists.wordpress.org
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
----------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100806/e67a75c7/attachment.htm>
More information about the theme-reviewers
mailing list