[wp-hackers] Comments broken on upgrade

[Thiago Becker]

Here is a patch. Looks good?


On Mon, 13 Sep 2004 13:12:15 -0300, Thiago Becker
<thiago.becker at gmail.com> wrote:
> Maybe this can uncover some mystery. ENUM index begins in 1, not in 0,
> so I think we must subtract 1 from comment_approved.
> 
> http://sql-info.de/mysql/gotchas.html#1_3
> http://dev.mysql.com/doc/mysql/en/ENUM.html
> 
> 
> 
> 
> On Mon, 13 Sep 2004 11:00:17 -0500, Matt Mullenweg <m at mullenweg.com> wrote:
> > Thiago Becker wrote:
> > > http://mosquito.wordpress.org/bug_view_advanced_page.php?bug_id=0000278
> > >
> > > I just upgraded from 1.0 to 1.3a CVS and the comments doesn't show. I
> > > managed to fix it, as you can see in
> > > http://www.monsterinc.org/sasquati/2004/09/13/137. It's quite ugly,
> > > since every  comment is set to 1 (approved).
> > > There must be a better way to fix it. I'll be looking for it tonite or tomorow.
> >
> > Yes this is a known bug with the upgrade script, the same thing happened
> > to me. If we can't figure out why switching from ENUM to INT would bump
> > approved comments to 2 we may just need to clean up after it.
> >
> > --
> > Matt Mullenweg
> >   http://photomatt.net | http://wordpress.org
> > http://pingomatic.com | more soon...
> >
> > _______________________________________________
> > hackers mailing list
> > hackers at wordpress.org
> > http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> >
> 
> 
> --
> ===================================
> Thiago Rafael Becker
> Computer Science Undergraduate
> thiago.becker at gmail.com
> ===================================
> 



-- 
===================================
Thiago Rafael Becker
Computer Science Undergraduate
thiago.becker at gmail.com
===================================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: upgrade-functions.php.diff
Type: application/octet-stream
Size: 485 bytes
Desc: not available
Url : /pipermail/hackers_wordpress.org/attachments/20040913/e44089be/upgrade-functions.php.obj