[wp-hackers] Need help upgrading CG-Related plugin to 1.3...

Kimmo Suominen kim at tac.nyc.ny.us
Tue Oct 26 11:50:08 UTC 2004


Dennis,

With your version you will get warnings if $_SERVER['QUERY_STRING']
is not set.

Regards,
+ Kim
-- 
<A HREF="http://kimmo.suominen.com/">Kimmo Suominen</A>

On Tue, Oct 26, 2004 at 12:49:21AM -0500, Dennis Williamson wrote:
> Oh!!!
> 
> What about:
> 
> if (!empty($_SERVER['QUERY_STRING'])) {
>   $_SERVER['REQUEST_URI'] .= '?' . $_SERVER['QUERY_STRING'];
> }
> 
> Isn't !empty() == isset(), always?
> 
> Dennis
> 
> At Monday 10/25/2004 11:04 PM, you wrote:
> >On Mon, 2004-10-25 at 23:26 -0400, David Chait wrote:
> >> Okay, so I just found the following code at the top of wp-settings.php:
> >>
> >> // Append the query string if it exists and isn't null
> >> if (isset($_SERVER['QUERY_STRING']) && !empty($_SERVER['QUERY_STRING'])) 
> >{
> >>  $_SERVER['REQUEST_URI'] .= '?' . $_SERVER['QUERY_STRING'];
> >> }
> >
> >Fixed.
> >
> >Ryan



More information about the hackers mailing list