[wp-hackers] Addition to check_comment(): return false if thepost is older than 21 days

Kitty kitty at mookitty.co.uk
Sat Oct 2 06:12:41 UTC 2004


On Fri, 2004-10-01 at 21:01, Owen Winkler wrote:
> However, the check_comments code should be augmented to allow any of *three*
> states to be returned:  Approved, Moderated, and Rejected.  The missing

I think that violates the rule of least surprise. I think if WP, at it's
core, just flat out deletes some comments, will be one of the funky
things that shouldn't be done. As it won't be something consistent.

The built in check_comments does what it does, check the comment and
accepts it or moderates it. Doing more is the job of plugins, and making
the moderation process more transparent is worthwhile. But making
check_comments do more processing is adding code in the wrong place.

So basically, we need to do one of several things:
o  Outsource all of check_comments to an included "system plugin"
o  Make check_comments pass on more info to plugins after the initial
   go/no-go checks are done. (Less DB queries that way)
o  Something else that hasn't been thought of yet.

I think at this point, code needs to be shown. Write up your favorite
method and post a diff. Let us have a whack at breaking it, and then
we'll have an idea of what works best.
-- 
Cheers!
Kitty
http://blog.mookitty.co.uk/
http://mookitty.co.uk/devblog/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : /pipermail/hackers_wordpress.org/attachments/20041001/a2de82d0/attachment.bin


More information about the hackers mailing list