[wp-hackers] Coding style (if : endif vs if {})

Rich Bowen rbowen at rcbowen.com
Fri Jul 9 18:01:28 UTC 2004


First, the disclaimer: I DO NOT want to create an issue where there is
none. I don't want to start a holy war. I have personal preferences, but
intend to adhere to whatever the local convention is. I'm much more
intested in making my patches easy to apply than in espousing a
particular style.

ok.

So I noticed this diff:
http://cvs.sourceforge.net/viewcvs.py/cafelog/wordpress/wp-admin/edit-comments.php?r1=1.28&r2=1.29
And I notice that in the diff, in addition to the functional change,
based on my submitted patch, there was also the style change of changing
a if { } block to an if : endif block. This appears to contradict the
instructions in the style guide.

What I need/want to know is a) whether it really matters, with respect
to future patches and b) which is in fact the preferred style.

Thanks for input on this matter, and 10k apologies ahead of time if
this, in any way, starts a holy war. That is not my intention, and
surely just wastes everyone's time.

-- 
I keep walking, from daybreak 'til the falling night
And as days turn into weeks and years,
And years turn into lifetimes, I just keep walking
              Dead man's rope, Sting, Sacred Love 



More information about the hackers mailing list