[wp-hackers] Quotes no longer escaped in get_links

[Robert Deaton]

XHTML attributes should always be put in double quotes anyways. 


On Sat, 18 Dec 2004 21:13:51 -0500, Basil Crow <lists at basilcrow.com> wrote:
> I have some items in the links manager that contain apostrophes in the
> description, such as "My friend's weblog." In calling get_links(), the
> $desc / $title variable in lines 185-186 doesn't escape the single
> quote, so when it is placed in the context of <a
> href='http://example.com/' rel='friend met' title='My friend's weblog'>,
> the apostrophe in the title attribute leads to incorrect and invalid
> markup. For the meantime, I changed line 197 to read $title = "
> title=\"$title\"";   By putting the HTML attribute in double quotes, the
> problem is worked around. But I'm hoping the devs were planning to fix
> this escaping problem. The last time I mentioned an blog-header.php bug,
> Ryan Boren fixed it in CVS a few days later, to my delightful surprise.
> Thanks Ryan!!!
> 
> --Basil
> 
> _______________________________________________
> hackers mailing list
> hackers at wordpress.org
> http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> 


-- 
--Robert Deaton
http://false-hopes.com/
A proud Linux, Firefox, and WordPress user.
Linux is not an operating system, its a way of life.