[wp-hackers] Coding Standards
Ing. Moises Kirsch
moikirsch at gmail.com
Tue Aug 31 13:24:08 UTC 2004
Probably the best thing to do is having averyone trying to use just
one coding standard such as Pear's
(http://pear.php.net/manual/en/standards.php).
just my two cents.
Moises
On Tue, 31 Aug 2004 05:00:10 -0700, hackers-request at wordpress.org
<hackers-request at wordpress.org> wrote:
> Send hackers mailing list submissions to
> hackers at wordpress.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> or, via email, send a message with subject or body 'help' to
> hackers-request at wordpress.org
>
> You can reach the person managing the list at
> hackers-owner at wordpress.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of hackers digest..."
>
> Today's Topics:
>
> 1. Re: Trackback fix for 1.2 Mingus (Ryan Boren)
> 2. Re: The same could be said for DOS-style newlines.
> (Sebastian Herp)
> 3. XML-RPC rewrite (Adam Keys)
> 4. Re: XML-RPC rewrite (Adam Keys)
> 5. Re: XML-RPC rewrite (John Watson)
> 6. Re: XML-RPC rewrite (Carthik Sharma)
> 7. Re: The same could be said for DOS-style newlines. (lowmagnet)
> 8. Re: The same could be said for DOS-style newlines. (Mike Little)
> 9. subversion repository? (kellan)
> 10. Re: subversion repository? (Matt Mullenweg)
> 11. Re: XML-RPC rewrite (m at tidakada.com)
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 30 Aug 2004 17:59:19 -0500
> From: Ryan Boren <ryan at boren.nu>
> Subject: Re: [wp-hackers] Trackback fix for 1.2 Mingus
> To: WordPress Hackers <hackers at wordpress.org>
> Message-ID: <1093906760.5764.21.camel at portnoy.fuzzybelly.org>
> Content-Type: text/plain
>
> On Sun, 2004-08-29 at 19:45 -0500, Matt Mullenweg wrote:
> > Craig Hartel wrote:
> >
> > > http://wordpress.org/support/3/11856
> > >
> > > I've tested it on my own install and it does indeed work.
> >
> > Do you have the same problem with trackbacks on the CVS version?
>
> I don't see how moving the do_action() to the end would change anything
> unless one of the plugins is calling exit, which is a bug with the
> plugin. In fact, we should probably move do_action() further up and
> then refetch content and excerpt from the database before doing
> trackbacks and pingbacks since some plugins modify the content and
> excerpt upon publish_post actions.
>
> Ryan
>
> ------------------------------
>
> Message: 2
> Date: Tue, 31 Aug 2004 01:45:44 +0200
> From: Sebastian Herp <newsletter at scytheman.net>
> Subject: Re: [wp-hackers] The same could be said for DOS-style
> newlines.
> To: hackers at wordpress.org
> Message-ID: <4133BC28.8050401 at scytheman.net>
> Content-Type: text/plain; charset=us-ascii; format=flowed
>
> lowmagnet wrote:
>
> >On Mon, Aug 30, 2004 at 07:57:37PM +0200, Sebastian Herp wrote:
> >
> >
> >>... and understand \r\n pretty well ... i don't know what problem you
> >>have ... ^M isn't even close to being a \r\n kind of thing ...
> >>
> >>
> >
> >\r *is* ^M. ^M is one half of the ^M^J (aka \r\n) combination.
> >
> >-eli
> >
> >
> You are right ... should have googled for it, sorry. Anyways, who uses
> ASCII nowadays :-)
>
> Seriously:
> The only time i actually saw a ^M was with "mcedit" after I edited the
> same file with the template-editor in wp-admin. "vi" does not show them,
> "pico" doesn't and a whole bunch of other editors, too ... Windows
> Ultraedit even asks politely what to do with the file (convert/keep) and
> has no problem working with both styles. So where is the problem? :-)
>
> ------------------------------
>
> Message: 3
> Date: Mon, 30 Aug 2004 18:50:39 -0500
> From: Adam Keys <adam at trmk.org>
> Subject: [wp-hackers] XML-RPC rewrite
> To: Hackers WordPress <hackers at wordpress.org>
> Message-ID: <6565F094-FADF-11D8-BAA0-000393BF1B60 at trmk.org>
> Content-Type: text/plain; charset=US-ASCII; format=flowed
>
> Matt mentioned that the XML-RPC code is currently being 'loved'. I
> posted a comment inquiring what the nature and status of this is, but
> there was no discussion. Pardon me if I missed the discussion here.
> So, what's the haps?
>
> My motivation for asking is that I've got a patch that implements
> MetaWeblog.newMediaObject. If you're not familiar with the posting
> APIs, it allows you to upload files using clients like Ecto. If you're
> into that sort of thing.
>
> If you'd like to use this code, drop me a line. Its really simple to
> apply.
>
> --
> ~akk
> http://therealadam.com
>
> ------------------------------
>
> Message: 4
> Date: Mon, 30 Aug 2004 18:54:50 -0500
> From: Adam Keys <adam at trmk.org>
> Subject: Re: [wp-hackers] XML-RPC rewrite
> To: hackers at wordpress.org
> Message-ID: <FB01EF2B-FADF-11D8-BAA0-000393BF1B60 at trmk.org>
> Content-Type: text/plain; charset=US-ASCII; format=flowed
>
> On Aug 30, 2004, at 6:50 PM, Adam Keys wrote:
>
> > Matt mentioned that the XML-RPC code is currently being 'loved'. I
> > posted a comment inquiring what the nature and status of this is, but
> > there was no discussion. Pardon me if I missed the discussion here.
> > So, what's the haps?
>
> In case you didn't get my ghastly colloquialism, I meant that the
> XML-RPC code is being fixed up/refactored.
>
> --
> ~akk
> http://trmk.org/~adam
>
> ------------------------------
>
> Message: 5
> Date: Mon, 30 Aug 2004 16:55:43 -0700
> From: John Watson <johnw1 at gmail.com>
> Subject: Re: [wp-hackers] XML-RPC rewrite
> To: hackers at wordpress.org
> Message-ID: <678068960408301655446ee97c at mail.gmail.com>
> Content-Type: text/plain; charset=US-ASCII
>
> Oh, we knew what you meant. *wink* *wink* *nudge* *nudge*
>
> On Mon, 30 Aug 2004 18:54:50 -0500, Adam Keys <adam at trmk.org> wrote:
> > On Aug 30, 2004, at 6:50 PM, Adam Keys wrote:
> >
> > > Matt mentioned that the XML-RPC code is currently being 'loved'. I
> > > posted a comment inquiring what the nature and status of this is, but
> > > there was no discussion. Pardon me if I missed the discussion here.
> > > So, what's the haps?
> >
> > In case you didn't get my ghastly colloquialism, I meant that the
> > XML-RPC code is being fixed up/refactored.
> >
> > --
> > ~akk
> > http://trmk.org/~adam
> >
> > _______________________________________________
> > hackers mailing list
> > hackers at wordpress.org
> > http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> >
>
> ------------------------------
>
> Message: 6
> Date: Mon, 30 Aug 2004 19:58:46 -0400
> From: Carthik Sharma <carthik at gmail.com>
> Subject: Re: [wp-hackers] XML-RPC rewrite
> To: hackers at wordpress.org
> Message-ID: <80f75db04083016583b1ad019 at mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> You can see the state of the xmlrpc.php file here:
> http://cvs.sourceforge.net/viewcvs.py/cafelog/wordpress/xmlrpc.php?rev=1.73&view=log
>
> Hope that helps, if a little.
>
> Carthik
>
> On Mon, 30 Aug 2004 16:55:43 -0700, John Watson <johnw1 at gmail.com> wrote:
> > Oh, we knew what you meant. *wink* *wink* *nudge* *nudge*
> >
> >
> >
> > On Mon, 30 Aug 2004 18:54:50 -0500, Adam Keys <adam at trmk.org> wrote:
> > > On Aug 30, 2004, at 6:50 PM, Adam Keys wrote:
> > >
> > > > Matt mentioned that the XML-RPC code is currently being 'loved'. I
> > > > posted a comment inquiring what the nature and status of this is, but
> > > > there was no discussion. Pardon me if I missed the discussion here.
> > > > So, what's the haps?
> > >
> > > In case you didn't get my ghastly colloquialism, I meant that the
> > > XML-RPC code is being fixed up/refactored.
> > >
> > > --
> > > ~akk
> > > http://trmk.org/~adam
> > >
> > > _______________________________________________
> > > hackers mailing list
> > > hackers at wordpress.org
> > > http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> > >
> >
> > _______________________________________________
> > hackers mailing list
> > hackers at wordpress.org
> > http://wordpress.org/mailman/listinfo/hackers_wordpress.org
> >
>
> --
> When nothing is done, nothing is left undone -- ������ L��ozi
>
> University of Central Florida
> Homepage: http://carthik.net
>
> ------------------------------
>
> Message: 7
> Date: Mon, 30 Aug 2004 20:29:54 -0400
> From: lowmagnet <lowmagnet at lowmag.net>
> Subject: Re: [wp-hackers] The same could be said for DOS-style
> newlines.
> To: hackers at wordpress.org
> Message-ID: <20040831002953.GE1712 at lowmag.net>
> Content-Type: text/plain; charset=us-ascii
>
> On Tue, Aug 31, 2004 at 01:45:44AM +0200, Sebastian Herp wrote:
> > Seriously:
> > The only time i actually saw a ^M was with "mcedit" after I edited the
> > same file with the template-editor in wp-admin. "vi" does not show them,
> > "pico" doesn't and a whole bunch of other editors, too ... Windows
> > Ultraedit even asks politely what to do with the file (convert/keep) and
> > has no problem working with both styles. So where is the problem? :-)
>
> One extra byte per line. But it's not really that much of a problem. BTW, my vi sees them, and they are highly annoying. But this is usually only when looking at plugins, and I just regexp them and clean them up for later editing.
>
> ------------------------------
>
> Message: 8
> Date: Tue, 31 Aug 2004 01:38:28 +0100
> From: Mike Little <journalized at gmail.com>
> Subject: Re: [wp-hackers] The same could be said for DOS-style
> newlines.
> To: hackers at wordpress.org
> Message-ID: <7235ce78040830173877380197 at mail.gmail.com>
> Content-Type: text/plain; charset=US-ASCII
>
> On Mon, 30 Aug 2004 20:29:54 -0400, lowmagnet <lowmagnet at lowmag.net> wrote:
> > On Tue, Aug 31, 2004 at 01:45:44AM +0200, Sebastian Herp wrote:
> > > Seriously:
> > > The only time i actually saw a ^M was with "mcedit" after I edited the
> > > same file with the template-editor in wp-admin. "vi" does not show them,
> > > "pico" doesn't and a whole bunch of other editors, too ... Windows
> > > Ultraedit even asks politely what to do with the file (convert/keep) and
> > > has no problem working with both styles. So where is the problem? :-)
> >
> > One extra byte per line. But it's not really that much of a problem. BTW, my vi sees them, and they are highly annoying. But this is usually only when looking at plugins, and I just regexp them and clean them up for later editing.
> >
>
> The reason for sticking to a standard is that if the line ends change
> back and forth between different contributions it really screws up
> the CVS diffs.
> So a standard was picked (Unix line ends \n only) and it should be adhered to.
>
> Mike
> --
> Mike Little
> http://zed1.com/journalized/
>
> ------------------------------
>
> Message: 9
> Date: Mon, 30 Aug 2004 23:07:27 -0700
> From: kellan <kellan at gmail.com>
> Subject: [wp-hackers] subversion repository?
> To: hackers at wordpress.org
> Message-ID: <422b9b38040830230729bb6777 at mail.gmail.com>
> Content-Type: text/plain; charset=US-ASCII
>
> As Sourceforge seems to be down tonight, it seemed like an auspicious
> time to follow up on whether the WP Subversion repository is up and
> running (as suggested by one of Matt's posts) and whether:
>
> a) it is publicly browsable?
> b) allows anonymous reads?
>
> thanks
> -kellan
>
> ------------------------------
>
> Message: 10
> Date: Tue, 31 Aug 2004 04:13:26 -0500
> From: Matt Mullenweg <m at mullenweg.com>
> Subject: Re: [wp-hackers] subversion repository?
> To: hackers at wordpress.org
> Message-ID: <41344136.2080008 at mullenweg.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> kellan wrote:
>
> > a) it is publicly browsable?
> > b) allows anonymous reads?
>
> Not quite yet.
>
> --
> Matt Mullenweg
> http://photomatt.net | http://wordpress.org
> http://pingomatic.com | more soon...
>
> ------------------------------
>
> Message: 11
> Date: Tue, 31 Aug 2004 10:11:56 +0000
> From: m at tidakada.com
> Subject: Re: [wp-hackers] XML-RPC rewrite
> To: hackers at wordpress.org
> Message-ID: <1093947116.41344eec88bae at tidakada.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Quoting Adam Keys <adam at trmk.org>:
>
> > Matt mentioned that the XML-RPC code is currently being 'loved'. I
> > posted a comment inquiring what the nature and status of this is, but
> > there was no discussion. Pardon me if I missed the discussion here.
> > So, what's the haps?
> >
> > My motivation for asking is that I've got a patch that implements
> > MetaWeblog.newMediaObject. If you're not familiar with the posting
> > APIs, it allows you to upload files using clients like Ecto. If you're
> > into that sort of thing.
>
> hi Adam,
>
> The XMLRPC rewrite is something I'm responsible of, it's a rewrite to use IXR
> instead of the aging phpxmlrpc code.
> It's not really about the age of the code, it's mostly about cleaner, easier
> code: with IXR, you can have your function return a string, and it'll know to
> serve a string to the client. With phpxmlrpc, you have to declare each and
> every returned value's type as a new xmlrpcval object, which really made the
> code hairy.
> Also, I spotted a dozen or so bugs and inconsistencies with the old xmlrpc code,
> that I'm addressing with this rewrite.
>
> As for metaWeblog.newMediaObject, the rewrite includes code for it, adapted from
> a patch from mycvs.org that was originally made for the phpxmlrpc version of the
> code.
> Talking about newMediaObject, if anyone knows any other client for Mac that is
> not Ecto and supports newMediaObject, please tell me about it so I can test
> further. At the moment, my demo client in PHP can send pictures to WP, while
> Ecto 1.1.8 cannot: it sends too many bytes...
>
> Michel
>
> ------------------------------
>
> _______________________________________________
> hackers mailing list
> hackers at wordpress.org
> http://wordpress.org/mailman/listinfo/hackers_wordpress.org
>
> End of hackers Digest, Vol 3, Issue 57
> **************************************
>
--
Moises Kirsch <moi(at)kirsch.com.mx>
Never underestimate the power of stupid people in large groups.
More information about the hackers
mailing list