[buddypress-trac] [BuddyPress Trac] #9289: BP Mentions autosuggest popup positioning bug

[buddypress-trac]

#9289: BP Mentions autosuggest popup positioning bug
--------------------------+-----------------------------
 Reporter:  cjerrells     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  low           |  Milestone:  Awaiting Review
Component:  Activity      |    Version:  14.3.2
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Hi! This is my first time reporting an issue, so let me start by saying
 thank you for the phenomenal work on BuddyPress through the ages :)

 I've found two possible bugs in bp-activity/js/mentions.js:

 1. The callback registration for "before reposition" is using the key
 "before_reposition" but in bp-core/js/vendor/jquery.atwho.js it's actually
 "beforeReposition". So as far as I can tell in my own testing, this
 function isn't being called. I believe it changed (7 years ago!) in
 revision 11795.

 2. Even with that fixed, the code doesn't seem to account for scrollable
 content boxes, resulting in the autosuggest popup appearing far down the
 page from where the user is typing if the body#tinymce is taller than its
 containing iframe.

 This is happening for us in bbPress TinyMCE topic/reply boxes, where we're
 using the approach [https://bbpress.org/forums/topic/buddypress-
 autocomplete-breaks-with-tinymce/ here] to enable @-mention autosuggest in
 that context.

 However, I have tested with vanilla WP/BP and could produce the same
 behaviour in a BP Nouveau message compose box (screenshot attached).

 On our site we have fixed this by:

 1. Changing the key to "beforeReposition" so that the code block runs

 2. Adding the following at line 677 (just after the iframeOffset
 handling):


 {{{ caret.top -= jQuery( atwhoDataValue.iframe ).contents().scrollTop();
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9289>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac