[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

buddypress-trac noreply at wordpress.org
Mon May 10 20:59:50 UTC 2021

#8139: Network Invitations and Membership Requests
 Reporter:  dcavins       |       Owner:  dcavins
     Type:  enhancement   |      Status:  closed
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:  fixed
 Keywords:  needs-patch   |

Comment (by imath):

 Hi @dcavins as it's not really possible to edit the default subnav item I
 believe your patch is fine. But it should be possible to edit the default
 subnav: see #8471

 Looking deeply at it, I have some other questions:

 1. Why all actions are not into the `src/bp-members/actions` directory
 (`bp_network_invitations_catch_send_action()` and
 `bp_members_invitations_action_handling()`) ?
 2. Why aren't you hooking to `bp_members_setup_nav` instead of
 `bp_setup_nav` ?

 More globally (it's not specific to the Invitations feature, it revealed
 it) I must say I'm a bit concerned by the `late_includes` hook as it
 happens before our navigation system is built so we can't be positive
 about what's screen function is being run when opening the user's primary
 nav item.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:80>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list