[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
--------------------------+----------------------
 Reporter:  dcavins       |       Owner:  dcavins
     Type:  enhancement   |      Status:  closed
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:  fixed
 Keywords:  needs-patch   |
--------------------------+----------------------

Comment (by imath):

 Hi @dcavins

 I'm fine with the suggested improvements. In
 [https://buddypress.trac.wordpress.org/attachment/ticket/8139/8139.09.02-capabilities.patch
 8139.09.02-capabilities.patch], you'll find some suggestions mainly about
 the Nouveau integration :

 - Instead of inserting the Feedback HTML output, we should use the
 template function `bp_nouveau_user_feedback()` and add the feedback
 messages into the `$feedback_messages` array inside the
 `bp_nouveau_get_user_feedback()` function.
 - Still in this function I've edited the message ID for the case no
 invitations are pending as it had previously a conflicting name with the
 groups no pending invites one (my bad).

 I've also edited the `'bp_members_invitations_view_send_screen'`
 capability check as when I'm logged in as a regular user I wasn't able to
 view the restricted message you used into your screenshot. Maybe you
 should give an extra check about this one 😉.

 Once you're positive about this last point, don't hesitate to commit.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:77>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac