[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
--------------------------+-----------------------
 Reporter:  dcavins       |       Owner:  (none)
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by dcavins):

 Thanks for your thorough review, @imath! Here are my questions and
 comments:

 > I've added the JavaScript & CSS parts for the member's Pending invites
 front-end screen: the PHP part still needs to be done.
 Can you explain what you mean here? Is this for Nouveau? The invite
 actions (resend/delete) are working for me in Nouveau, so I'm not sure
 what is missing.

 > Adding a name to the invitation email.
 I'm not opposed to this idea, but think we should move it to a future
 enhancement, because I think it would require adding a meta table for
 invitations to store that info. (We could pass it through from the form
 for the initial email, but then resends would miss that info.)

 > The email subject is empty a BP Email invite is sent.
 The email subject is filled in on my installation. Maybe you could use the
 "reinstall emails" tool on your dev environment to test? My example emails
 say "Adminer has invited you to join bpdev" for the subject, where
 "adminer" is the display name of the user who created the invite.

 > The email invitation unsubscribe link doesn't seem to be handled yet.
 Right, that was relying on the new opt-outs code to be added, so I should
 be able to do it easily now.

 > The super admin cannot view another member's Invitations front-end
 pages, is this on purpose? If so, maybe the navigations shouldn't be
 displayed for him.
 The super admin should be able to see the list, at least. Showing the
 "send invites" form seems a little weird, since the admin should be doing
 that elsewhere. Do you agree?

 Thanks again for your review and your patches!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:44>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac