[buddypress-trac] [BuddyPress Trac] #8454: Feed link functions should short circuit when feeds are disabled

[buddypress-trac]

#8454: Feed link functions should short circuit when feeds are disabled
--------------------------+---------------------
 Reporter:  sippis        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  8.0.0
Component:  Activity      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by imath):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 8.0.0


Comment:

 Hi @sippis

 Thanks a lot for your feedback and for your contribution. It's nice to see
 you on this Trac 😍

 I confirm we need to improve this part. Instead of make links return null,
 I chose to avoid to display the HTML output if the feeds are disabled. I
 also added some improvements to be able to deactivate all or specific
 feeds. The filter now returns a second parameter with the feed identifier.

 Doing this: `add_filter( 'bp_activity_enable_feeds', '__return_false' );`
 is still disabling all feeds 😉

 I also added some BP Nouveau improvements as on Activity directory or on
 Member's activity pages the link was always the main activity feed, which
 is wrong. Now according to what you display you get the right feed. Eg: on
 the 'My Groups' tab you'll get the activity feeds of the groups you belong
 too.

 Let's fix this in 8.0.0!

 PS: I will close the other ticket as duplicate.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8454#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac