[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
-------------------------------------+-----------------------
 Reporter:  dcavins                  |       Owner:  (none)
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  8.0.0
Component:  Registration             |     Version:  5.0.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |
-------------------------------------+-----------------------
Changes (by imath):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 Hi @dcavins,

 I've just tested the patch. It works pretty well, thanks a lot for your
 work on it. I'm now going to work on the Nouveau integration. Here are
 some possible improvements I'm suggesting about current patch :)

 - Activate and register page could be automatically created if
 registration are disabled and the admin chose to activate network invites.
 - "Pending Invites" instead of "Sent invites" for the user's front-end
 profile
 - "Send Invite" instead of "Invite new members" for the user's front-end
 profile
 - Some information about what will happen once the form has been
 submitted.
 - Form to send invites as default screen for the user's front-end profile
 - "was invited by user and became a registered member" for the new member
 activity
 - Screen notification/email notification to inform the user was
 successfully invited.
 - New Email setting to disable email notification
 - Install email on upgrade (see example in #8428)
 - #8428 The welcome email, should any specific message be included in it?
 - Let's move Invitations Management into BuddyPress tools. We should also
 to the same progressively for Signup Management I believe.
 -
 [https://buddypress.trac.wordpress.org/attachment/ticket/8139/8139.04.fixInvitationsManagementNotices.patch
 8139.04.fixInvitationsManagementNotices.patch] is fixing some notices. FYI
 it's possible to reach the resend confirmation screen using the Resend
 Bulk action even for accepted invites.
 - in `bp_get_members_invitations_pagination_count()` make sure to use
 strict comparison eg: `1 === (int) $query_loop->total_invitation_count`
 - BP_Members_Admin::members_invitations_admin_load() this part looks weird
 `( -1 == $doaction )` + some strict comparison to make eg: `'do_resend'
 === $doaction`, `'do_delete' === $doaction`
 - I missed the missing strict comparison about `'resend' === $action` in
 8139.04.fixInvitationsManagementNotices.patch
 - Another strict comparison missing in
 BP_Members_Invitations_Template::invitations() ->
 `$this->current_invitation + 1 === $this->current_invitation_count`.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:37>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac