[buddypress-trac] [BuddyPress Trac] #8367: PHP8: implode() no longer accepts deprecated order of args

buddypress-trac noreply at wordpress.org
Fri Sep 25 02:02:26 UTC 2020


#8367: PHP8: implode() no longer accepts deprecated order of args
--------------------------+---------------------
 Reporter:  dd32          |       Owner:  imath
     Type:  defect (bug)  |      Status:  closed
 Priority:  high          |   Milestone:  6.4.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12733" 12733]:
 {{{
 #!CommitTicketReference repository="" revision="12733"
 Admin: use `implode()` the right way into the BP site health panel

 The right order of arguments of this function is `$glue`  first and then
 `$pieces`, not the other way around as it was so far. Moreover as of PHP8
 (Scheduled for Nov 26th), `implode( $glue, $pieces )` only accepts args in
 that order, it no longer supports passing the `$glue` as the second arg.

 Props dd32

 Fixes #8367 (6.0 Branch)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8367#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list