[buddypress-trac] [BuddyPress Trac] #8390: PHP8 no longer accepts a function required parameter to follow an optional one

[buddypress-trac]

#8390: PHP8 no longer accepts a function required parameter to follow an optional
one
----------------------------+---------------------
 Reporter:  imath           |       Owner:  imath
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  7.0.0
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |
----------------------------+---------------------
Changes (by imath):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12780" 12780]:
 {{{
 #!CommitTicketReference repository="" revision="12780"
 Prevent a PHP 8.0 deprecated notice about optional function argument

 The `bp_admin_get_wp_nav_menu_items()` funciton was introduced in 7.0.0 to
 fix an issue with the BuddyPress Members WP Nav Menu items. It was wrongly
 using an optional argument before a required one. As PHP 8.0 no longer
 accepts this practice, both arguments of the function will be required 😇.

 Fixes #8390
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8390#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac