[buddypress-trac] [BuddyPress Trac] #8388: BP_XProfile_ProfileData::delete_data_for_user() doesn't clear cache

[buddypress-trac]

#8388: BP_XProfile_ProfileData::delete_data_for_user() doesn't clear cache
------------------------------------+-----------------------
 Reporter:  dd32                    |       Owner:  dcavins
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  6.4.0
Component:  Extended Profile        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------
Changes (by imath):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 hi @r-a-y

 Thanks a lot for your feedback, I'm fine with choosing version 2. That
 being said I'm a bit concerned about having a class method that we don't
 use anymore in our code. `BP_XProfile_ProfileData::delete_data_for_user`
 is only used into `xprofile_remove_data()`. So If you want to go with
 8388.03.diff, then `BP_XProfile_ProfileData::delete_data_for_user` should
 probably be deprecated.

 In
 [https://buddypress.trac.wordpress.org/attachment/ticket/8388/8388.04.diff
 8388.04.diff], I'm suggesting another alternative to avoid deprecating the
 method (in a minor release, I'm unsure it's a good idea) and to keep DB
 stuff into `BP_XProfile_ProfileData::delete_data_for_user`.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8388#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac