[buddypress-trac] [BuddyPress Trac] #8321: Add delete confirmation screen for XProfile fields

[buddypress-trac]

#8321: Add delete confirmation screen for XProfile fields
----------------------------+----------------------
 Reporter:  oztaser         |       Owner:  slaFFik
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  7.0.0
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-refresh   |
----------------------------+----------------------
Changes (by imath):

 * keywords:  has-patch => needs-refresh


Comment:

 Hi @oztaser

 I've just tested your patch. It works great. Thanks again for your work on
 this. I believe we should improve it a bit:

 1. making sure the i18n function are not using PHP code inside them.
 Instead of `<?php esc_html_e( sprintf ( 'Delete %s', $field_type ),
 'buddypress' ) ?>` we should use `<?php printf( esc_html__( 'Delete %s',
 'buddypress' ), $field_type ); ?>`.
 2. making sure there's a final `;` after inline PHP functions.

 8321.improvements.patch is containing these improvements.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8321#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac