[buddypress-trac] [BuddyPress Trac] #8187: members page takes over home page of subsite "members" in a multisite subdirectory installation

[buddypress-trac]

#8187: members page takes over home page of subsite "members" in a multisite
subdirectory installation
--------------------------+---------------------
 Reporter:  santiazpi2    |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.0.0
Component:  Core          |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by imath):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 6.0.0


Comment:

 Here's my review about this report.

 1) I wasn't able to reproduce the described issue. If WordPress Multisite
 is installed using subdirectories and BuddyPress is activated on a sub
 site having the `members` path, then the permalink to the Members
 component is `site.url/members/members/` and `site.url/members` is rightly
 displaying subsite's home page.

 2) But I've found a potential slug conflict: when BuddyPress is network
 activated on a "subdirectory installed" WordPress Multisite & if a new
 site is created using the slug of a BP Component of the root site's.

 To fix this issue, we need to add the component's page slug to the
 WordPress's `subdirectory_reserved_names`. See the beginning of the
 [https://buddypress.trac.wordpress.org/attachment/ticket/8187/8187.patch
 attached patch].

 I've added unit tests and deprecated 2 functions we are no more using.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8187#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac