[buddypress-trac] [BuddyPress Trac] #8149: Incorrect 'ids' param passed to `groups_get_invites()` causes all invites to be returned

buddypress-trac noreply at wordpress.org
Wed Oct 30 18:52:49 UTC 2019


#8149: Incorrect 'ids' param passed to `groups_get_invites()` causes all invites
to be returned
--------------------------+----------------------
 Reporter:  boonebgorges  |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  closed
 Priority:  highest       |   Milestone:  5.1.0
Component:  Groups        |     Version:  5.0.0
 Severity:  critical      |  Resolution:  fixed
 Keywords:  commit        |
--------------------------+----------------------
Changes (by dcavins):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12486" 12486]:
 {{{
 #!CommitTicketReference repository="" revision="12486"
 Fix incorrect parameter key in groups_get_invites() call.

 `BP_Invitation::get()` accepts an `id` parameter, but I was passing a
 misnamed `ids` parameter to the function in the cache-building routine
 within `bp_get_user_groups()`, resulting in all invitations being
 returned.

 This changeset corrects the misnamed key and also skips the fetch-and-
 cache routine if no uncached items are found.

 Props boonebgorges.

 Fixes #8149.
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8149#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list