[buddypress-trac] [BuddyPress Trac] #8144: Use of bp_core_signup_send_activation_key not checked while querying for signups

[buddypress-trac]

#8144: Use of bp_core_signup_send_activation_key not checked while querying for
signups
-----------------------------------------+---------------------
 Reporter:  zishanj                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.0.0
Component:  Members                      |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+---------------------

Comment (by zishanj):

 Sorry about the confusion. Just review it again in depth, here are some
 suggested changes in file src/bp-members/classes/class-bp-signup.php from
 patch 8144:

 On line 243:

 {{{
 $signup->date_sent = $signup->registered;
 }}}

 Should be changed to:

 {{{
 $signup->date_sent = '0000-00-00 00:00:00';
 }}}

 I think it should be default to 0 otherwise showing registered date
 confuse the admin if he has disabled the send registration key.

 On line 262:

 {{{
 $signup->count_sent = 1;
 }}}

 should be changed to

 {{{
 $signup->count_sent = 0;
 }}}

 It should be default to 0 to avoid confusion in case admin has disabled
 the send registration key.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8144#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac