[buddypress-trac] [BuddyPress Trac] #8163: WP 5.3 use of the spread operator, our PHP required version (5.3) & BP_Walker_Nav_Menu

[buddypress-trac]

#8163: WP 5.3 use of the spread operator, our PHP required version (5.3) &
BP_Walker_Nav_Menu
-----------------------------------+---------------------
 Reporter:  imath                  |       Owner:  imath
     Type:  defect (bug)           |      Status:  closed
 Priority:  high                   |   Milestone:  5.1.0
Component:  Core                   |     Version:  1.7
 Severity:  major                  |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12500" 12500]:
 {{{
 #!CommitTicketReference repository="" revision="12500"
 Compat classes to handle `Walker_Nav_Menu::walk()` changes in WP 5.3

 WordPress 5.3 modified the `Walker_Nav_Menu::walk()` signature adding a
 third parameter to the method that is using the spread operator.
 johnjamesjacoby quickly fixed the issue in [12497] when PHP >=5.6.

 As our current PHP required version is 5.3, we need to provide a temporary
 compatibility mechanism to make sure our `BP_Walker_Nav_Menu` will not
 generate errors when the PHP version is lower than 5.6 before raising the
 PHP required version in our next major release.

 props timothybjacobs, boonebgorges, imath

 Fixes #8163 (5.0 branch)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8163#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac