[buddypress-trac] [BuddyPress Trac] #8167: Nouveau: Inviter cannot remove group invitation

buddypress-trac noreply at wordpress.org
Tue Nov 26 12:21:54 UTC 2019


#8167: Nouveau: Inviter cannot remove group invitation
--------------------------+------------------------------
 Reporter:  dcavins       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Groups        |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by imath):

 Hi @dcavins thanks a lot for your patch, I believe this might also be the
 case for BP Legacy. Could you check if it is the case ?

 About the patch it looks good, but I’d feel safer if :
 - `$current_user` was renamed `$current_user_id`
 - the if inside the foreach would use strict comparison `===ˋ,
 - we had a unit test for this.

 Is this a side effect of the BP Invites API we should fix it 5.1.0 ?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8167#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list