[buddypress-trac] [BuddyPress Trac] #8031: Messages - Alert icon is shown twice which is not intuitive.

[buddypress-trac]

#8031: Messages - Alert icon is shown twice which is not intuitive.
--------------------------+------------------------------
 Reporter:  pooja1210     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Core          |     Version:  4.1.0
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by imath):

 Hi @boonebgorges

 Sorry it took me some time to give you the quick reply. Looking at the
 code I was a bit surprised to see this amount of html tags. I thought I
 lost my mind when I wrote this line ! So I've searched & found the
 [https://github.com/buddypress/next-template-
 packs/commit/10ef7aaabc1363e141b96406f08221f5dafddd67#diff-
 ef03370c54098a0f775dc68f62368ac4 origin of it] to understand what happened
 and to feel better about myself :)

 Now about using a list. I'd say why not. But I think I'd probably put it
 back the way it was when I've built it in the first place, because this
 part is using a JS Template that is doing `<p>{{{data.message}}}</p>`. So
 if there's only one message I can imagine some users might report why are
 you using a list inside a paragraph for only one element ?

 About improving it so that there are multiple distinct feedbacks, you're
 right about the fact it would complexify a bit for the reasons you
 mentioned (clearing etc).

 But if you think it's a better approach, we can take the time to use
 multiple distinct feedbacks ;)

 PS: 8031.2.diff is "the way it was when I've built it in the first place"
 :)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8031#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac