[buddypress-trac] [BuddyPress Trac] #8026: Default avatar choices show same generated icon in general discussion settings

[buddypress-trac]

#8026: Default avatar choices show same generated icon in general discussion
settings
--------------------------+---------------------
 Reporter:  netweblogic   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by boonebgorges):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 5.0.0


Comment:

 Thanks for the ticket. I'm fairly sure that this is a very old issue in BP
 - I've noticed it before but never bothered to try figuring it out :)

 I had to do the following to fix it. See [attachment:"8026.diff"]:
 1. If `force_default`, don't attempt to scan for uploaded images.
 2. If `force_default`, ensure that the `d` param is set to `default` as
 passed from `get_avatar()`
 3. Don't do the `default_avatar` override if `force_default`

 @r-a-y Since you have touched this in the past, maybe you could give a
 brief review?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8026#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac