[buddypress-trac] [BuddyPress Trac] #8175: Calling `wp_delete_user()` on multisite should not trigger data deletion

[buddypress-trac]

#8175: Calling `wp_delete_user()` on multisite should not trigger data deletion
--------------------------+------------------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Members       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+------------------------------

Comment (by boonebgorges):

 [attachment:"8175.diff"] shows how we might address this problem in the
 case of XProfile. Other components would work similarly. I've chosen to
 create a new callback for the 'delete_user' hook, where we do an
 `is_multisite()` check. In this way, we directly parallel the
 `is_multisite()` check in `wp_delete_user()`.
 https://core.trac.wordpress.org/browser/tags/5.3/src/wp-
 admin/includes/user.php?marks=422#L411

 Two questions for the group:

 1. Do others agree that this is a bug that BP should address? (The
 semantics in WP are a mess, but we can only control what we can control.)
 2. Do others agree that [attachment:"8175.diff"] is a decent approach? I
 can think of a couple other strategies but they're not as clear as this
 one.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8175#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac