[buddypress-trac] [BuddyPress Trac] #8167: Nouveau: Inviter cannot remove group invitation

[buddypress-trac]

#8167: Nouveau: Inviter cannot remove group invitation
--------------------------+-----------------------
 Reporter:  dcavins       |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.1.0
Component:  Groups        |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by dcavins):

 I've just attached a simpler patch that uses the same logic in the
 "delete" routine as was used in the "can_edit" permissions check.

 I also fixed what I suspect was a mistake, where the error message
 suggests that we are checking for membership, but the logic was checking
 for an outstanding membership request. Neither case is that likely,
 because both actions (joining a group or a member both requesting
 membership and being invited to a group) would cause the invitation to be
 removed, so I'm not sure what problem that check is avoiding. I did change
 the check to mirror the error message, though.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8167#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac