[buddypress-trac] [BuddyPress Trac] #8127: Possible DB error during BP 5.0.0 upgrade

[buddypress-trac]

#8127: Possible DB error during BP 5.0.0 upgrade
--------------------------+---------------------
 Reporter:  imath         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by johnjamesjacoby):

 👍

 ----

 Should be `empty( $records )` instead of `!` to avoid type juggling.

 (It is checking for a non-empty result, but `get_results()` returns
 `array|object|null` – not a boolean.)

 Cleaning all of those up could probably it's own issue at this point
 though, so I'm OK with either.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8127#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac