[buddypress-trac] [BuddyPress Trac] #7997: PHP version compatibility sniffs

buddypress-trac noreply at wordpress.org
Tue Aug 6 12:31:50 UTC 2019

#7997: PHP version compatibility sniffs
 Reporter:  boonebgorges      |       Owner:  netweb
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |

Comment (by jrf):

 Just came across this ticket.

 While I - of course - fully support adding `PHPCompatibilityWP` to the QA
 toolset, **it is ''not'' a replacement for linting code**.

 When PHPCompatibility encounters parse errors which are not typically to
 do with PHP cross-version compatibility, it will ignore them and not
 notify you of these.

 Also, in case of parse errors, the results of PHPCompatibility may not be
 reliable as the file may be tokenized incorrectly by PHP/PHPCS because of
 the parse errors.

 I'd strongly recommend using `php -l` against at least the lowest and
 highest PHP version, if not lowest/highest of each PHP major in addition
 to using PHPCompatibility.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7997#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list