[buddypress-trac] [BuddyPress Trac] #7822: Nouveau: Settings > Email menu item not visible

buddypress-trac noreply at wordpress.org
Fri May 11 18:32:56 UTC 2018

#7822: Nouveau: Settings > Email menu item not visible
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  highest       |   Milestone:  3.0
Component:  Settings      |     Version:
 Severity:  blocker       |  Resolution:
 Keywords:  has-patch     |

Comment (by boonebgorges):

 Replying to [comment:10 r-a-y]:
 > Can duplicate on a fresh install.
 > The reason why my main development testing site failed to pick up this
 issue is due to the fact that I had a plugin registering on the
 `'bp_notification_settings'` hook at all times.
 > Here's a cheeky idea.  Why not register a dummy hook to
 `'bp_notification_settings'` for each component needing to display the
 "Settings > Email" tab to appease the `has_action()` check?  See
 > I guess the other issue is whether a plugin would need to access this
 `<table>` markup outside the "Settings > Email" page.

 Eesh, that is cheeky. I don't like it :) The `has_action()` checks are
 already a kludge. Your trick would make it so that `has_action(
 'bp_notification_settings' )` is no longer an accurate check, since anyone
 wanting to remove all of these notifications sections would have to remove
 both the notification callback *and* `__return_empty_string`. My
 suggestion is much more straightforward (though obviously a much bigger
 patch, and a very small step backward in your quest to reduce the amount
 of code loaded).

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7822#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list