[buddypress-trac] [BuddyPress Trac] #7728: BP-Nouveau: Fix Heading Levels

buddypress-trac noreply at wordpress.org
Thu May 10 14:06:04 UTC 2018

#7728: BP-Nouveau: Fix Heading Levels
 Reporter:  mercime                        |       Owner:  mercime
     Type:  defect (bug)                   |      Status:  reopened
 Priority:  normal                         |   Milestone:  3.0
Component:  Templates                      |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  Commit dev-feedback has-patch  |

Comment (by imath):

 Hi @mercime

 Just tested the 3 patches. Great work!

 I would only suggest for 7728-groups-remaining-headings.patch that the
 `Group Activities` header might be a `H3` because upper there's a `H2` for
 `Post Update`. You might need to check if the user is a member of the
 group though because this `Post Update` might not be there in that case.

 I would also suggest that there could be some look alike between single
 items (Member/Group). For instance, i was a bit surprised to see a header
 for the Group Activities where there's not one for the User Activities.

 I think the Activities Header is interesting for both component when the
 front page is the activity and not a custom front page, otherwise i'd
 probably `bp-screen-reader-text` it :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7728#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list