[buddypress-trac] [BuddyPress Trac] #7732: BP-Nouveau: Group Creation Menu issues

buddypress-trac noreply at wordpress.org
Tue Mar 27 21:33:53 UTC 2018

#7732: BP-Nouveau: Group Creation Menu issues
 Reporter:  mercime       |       Owner:  David Cavins
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Templates     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |

Comment (by mercime):

 Replying to [comment:1 hnla]:
 > How have these links gone wonky last time I checked create step they
 were ok have we changed something??

 @hnla Noticed those menu links only by chance last night when I tapped the
 screen which went to the 404 page.

 > As for enhancements we best focus on other areas first, these steps are
 desperately in need of a re-write altogether which might have made
 updating styling worthwhile but for the momentlets back burner.

 Perhaps a minor change from UL to semantic OL if there's time? :D

 Replying to [comment:4 David Cavins]:
 > 1. Fix links in create menu. Problem here was an `echo` function used
 inside of an `echo` statement.

 Thank you.

 > 2. The group create menu contains links which are not links at all, e.g.
 <a disabled="disabled">5. Invites</a>. Replaced with the link to the
 farthest accessible step. I'm not sure this is great. It's a real link,
 and doesn't take you somewhere you're not supposed to go yet, but it seems
 a bit off.

 @dcavins, you're right that a link that doesn't take you somewhere is off.
 Sorry, my post above was not complete. The `disabled` attribute can only
 be applied to the following HTML elements:  `<button>`, `<input>`,
 `<select>`, `<textarea>`, `<optgroup>`, `<option>`, and `<fieldset>`.
 [https://www.w3.org/TR/html5/disabled-elements.html W3C.org]
 [https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes Mozilla
 Developer] (the `keygen` and `command` elements listed in Mozilla are
 Read why this proposal to allow using the disabled attribute for a link is
 not going to happen]

 > 3. Periods are missing after #s 1 to 3 in the menu. Fixed. These periods
 are hardcoded in the output, which could be a problem for sites not in
 English, maybe? I'm not sure about that.

 @dcavins [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/functions.php#L230 number_format_i18n]?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7732#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list