[buddypress-trac] [BuddyPress Trac] #7608: Use BP_Groups_Group visibility and access properties.

buddypress-trac noreply at wordpress.org
Wed Mar 7 12:56:50 UTC 2018

#7608: Use BP_Groups_Group visibility and access properties.
 Reporter:  dcavins      |       Owner:  djpaul
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  3.0
Component:  Groups       |     Version:  2.9.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by dcavins):

 In [changeset:"11896"]:
 #!CommitTicketReference repository="" revision="11896"
 Revert bp_group_is_visible() to check access.

 In r11761, `bp_group_is_visible()` was changed to rely on the
 `BP_Groups_Group->is_visible` property. However, `bp_group_is_visible()`
 has been used to check access, not visibility, making the new logic, even
 though it seems sensible, wrong.

 This changeset also replaces `bp_group_is_visible()` in the BP Nouveau
 template parts, to start retiring this no-longer-correctly-named function.

 Props r-a-y.

 See #7608.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7608#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list